Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
On Mon, Jun 27, 2016 at 10:35 PM, Zong Kai LI wrote: > +static void >> +check_and_add_supported_dhcp_opts_to_sb_db(struct northd_context *ctx) >> +{ >> +static bool nothing_to_add = false; >> + >> +if (nothing_to_add) { >> +return; >> +} >> + >> +struct hmap dhcp_opts_to_a

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
Hi Zonk Kai Li, Thanks for the review. See inline for the comments. On Mon, Jun 27, 2016 at 9:38 PM, Zong Kai LI wrote: > + >> +eth.dst = eth.src; >> +eth.src = E; >> +ip4.dst = O; >> +ip4.src = S; >> +udp.src = 67; >> +udp.dst = 68; >> +outport = P; >> +inport = ""; /* Allow sending out

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Zong Kai LI
> > +static void > +check_and_add_supported_dhcp_opts_to_sb_db(struct northd_context *ctx) > +{ > +static bool nothing_to_add = false; > + > +if (nothing_to_add) { > +return; > +} > + > +struct hmap dhcp_opts_to_add = HMAP_INITIALIZER(&dhcp_opts_to_add); > +for (size_t i

Re: [ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Zong Kai LI
> > + > +eth.dst = eth.src; > +eth.src = E; > +ip4.dst = O; > +ip4.src = S; > +udp.src = 67; > +udp.dst = 68; > +outport = P; > +inport = ""; /* Allow sending out inport. */ > +output; > + > + > + > + where E is the server MAC address and S > is the > + ser

[ovs-dev] [PATCH v2] ovn-northd: Add logical flows to support native DHCPv4

2016-06-27 Thread Numan Siddique
OVN implements a native DHCPv4 support which caters to the common use case of providing an IP address to a booting instance by providing stateless replies to DHCPv4 requests based on statically configured address mappings. To do this it allows a short list of DHCPv4 options to be configured and app