Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-06 Thread Ben Pfaff
On Thu, Nov 06, 2014 at 09:36:19AM -0800, Pravin Shelar wrote: > On Wed, Nov 5, 2014 at 4:44 PM, Ben Pfaff wrote: > > On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote: > > I don't understand why struct udp_header is now marked as packed, or > > why struct gre_base_hdr is marked as a

Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-06 Thread Ben Pfaff
On Thu, Nov 06, 2014 at 10:19:14AM -0800, Jarno Rajahalme wrote: > On Nov 6, 2014, at 9:36 AM, Pravin Shelar wrote: > >> I think that all of the flows added to the tnl-ports classifier have > >> the same wildcard pattern. I don't know why a classifier is the best > >> choice; wouldn't an hmap wor

Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-06 Thread Jarno Rajahalme
On Nov 6, 2014, at 9:36 AM, Pravin Shelar wrote: >> I think that all of the flows added to the tnl-ports classifier have >> the same wildcard pattern. I don't know why a classifier is the best >> choice; wouldn't an hmap work? >> The lookup should be RCU, so hmap would not work. cmap would th

Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-06 Thread Pravin Shelar
On Wed, Nov 5, 2014 at 4:44 PM, Ben Pfaff wrote: > On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote: >> Following patch adds support for userspace tunneling. Tunneling >> needs three more component first is routing table which is configured by >> caching kernel routes and second is

Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-05 Thread Ben Pfaff
On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote: > Following patch adds support for userspace tunneling. Tunneling > needs three more component first is routing table which is configured by > caching kernel routes and second is ARP cache which build automatically > by snooping arp.

Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-05 Thread Pravin Shelar
On Wed, Nov 5, 2014 at 5:59 AM, Flavio Leitner wrote: > On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote: >> Following patch adds support for userspace tunneling. Tunneling >> needs three more component first is routing table which is configured by >> caching kernel routes and secon

Re: [ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-05 Thread Flavio Leitner
On Sun, Nov 02, 2014 at 09:29:28PM -0800, Pravin B Shelar wrote: > Following patch adds support for userspace tunneling. Tunneling > needs three more component first is routing table which is configured by > caching kernel routes and second is ARP cache which build automatically > by snooping arp.

[ovs-dev] [PATCH v2] openvswitch: Userspace tunneling.

2014-11-03 Thread Pravin B Shelar
Following patch adds support for userspace tunneling. Tunneling needs three more component first is routing table which is configured by caching kernel routes and second is ARP cache which build automatically by snooping arp. And third is tunnel protocol table which list all listening protocols whi