Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

On Tue, Apr 08, 2014 at 11:17:32AM -0700, Ben Pfaff wrote: > On Tue, Apr 08, 2014 at 09:35:20AM +0900, Simon Horman wrote: > > Uniformly wait for calls to ovs-ofctl exit using > > OVS_APP_EXIT_AND_WAIT() in the test-suite. > > > > Signed-off-by: Simon Horman > > > > v2 > > * Always use OVS_APP_E

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

On Tue, Apr 08, 2014 at 09:35:20AM +0900, Simon Horman wrote: > Uniformly wait for calls to ovs-ofctl exit using > OVS_APP_EXIT_AND_WAIT() in the test-suite. > > Signed-off-by: Simon Horman > > v2 > * Always use OVS_APP_EXIT_AND_WAIT(ovs-ofctl) instead of > OVS_WAIT_UNTIL([ovs-appctl -t ovs-of

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

On Tue, Apr 08, 2014 at 10:20:54AM +0900, YAMAMOTO Takashi wrote: > > On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > >> > Uniformly wait for calls to ovs-ofctl exit using > >> > OVS_APP_EXIT_AND_WAIT() in the test-suite. > >> > >> are they all necessary to avoid some races? >

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

> On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: >> > Uniformly wait for calls to ovs-ofctl exit using >> > OVS_APP_EXIT_AND_WAIT() in the test-suite. >> >> are they all necessary to avoid some races? >> >> in commit 0c473314, i intended to make it wait only when necessary. >>

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

On Tue, Apr 08, 2014 at 10:00:47AM +0900, YAMAMOTO Takashi wrote: > > Uniformly wait for calls to ovs-ofctl exit using > > OVS_APP_EXIT_AND_WAIT() in the test-suite. > > are they all necessary to avoid some races? > > in commit 0c473314, i intended to make it wait only when necessary. > ie. only

Re: [ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

> Uniformly wait for calls to ovs-ofctl exit using > OVS_APP_EXIT_AND_WAIT() in the test-suite. are they all necessary to avoid some races? in commit 0c473314, i intended to make it wait only when necessary. ie. only tests which have multiple "ovs-ofctl --pidfile". YAMAMOTO Takashi > > Signed-

[ovs-dev] [PATCH v2] ofproto-dpif: Always wait for ovs-ofctl exit in test-suite

Uniformly wait for calls to ovs-ofctl exit using OVS_APP_EXIT_AND_WAIT() in the test-suite. Signed-off-by: Simon Horman v2 * Always use OVS_APP_EXIT_AND_WAIT(ovs-ofctl) instead of OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit]) --- tests/ofproto-dpif.at | 36 ++-