[sorry about the delay, I kind of lost this message in my inbox]
On Wed, Aug 01, 2012 at 11:14:52PM +1200, Joe Stringer wrote:
> I've got a working copy that fixes the above criticisms, following the
> suggested approach of verifying correct ordering at the end of the
> parsing functions. I have a
Hi Ben,
I've got a working copy that fixes the above criticisms, following the
suggested approach of verifying correct ordering at the end of the
parsing functions. I have a few queries regarding this.
In the above patch, there is a test for "ofproto - packet-out with
metadata (NXM)", in tests/of
On Mon, Jul 16, 2012 at 09:27:08AM -0700, Ben Pfaff wrote:
> On Mon, Jul 16, 2012 at 07:38:39PM +1200, Joe Stringer wrote:
> > On 13 July 2012 16:01, Ben Pfaff wrote:
> > > ...I think that we should restrict parsing NXAST_WRITE_METADATA to one
> > > entry and only as the final entry.
> ...
> > > T
On Mon, Jul 16, 2012 at 07:38:39PM +1200, Joe Stringer wrote:
> On 13 July 2012 16:01, Ben Pfaff wrote:
> > ...I think that we should restrict parsing NXAST_WRITE_METADATA to one
> > entry and only as the final entry.
...
> > There are only two important paths into ofpacts: parsing of binary
> > i
On 13 July 2012 16:01, Ben Pfaff wrote:
> On Fri, Jul 13, 2012 at 02:48:49PM +1200, Joe Stringer wrote:
>> On 13 July 2012 12:02, Ben Pfaff wrote:
>> > Suppose you fix that; it should not be hard (just remove an "else"
>> > keyword, I think). Then, second, the semantics implemented here will
>>
On Fri, Jul 13, 2012 at 02:48:49PM +1200, Joe Stringer wrote:
> On 13 July 2012 12:02, Ben Pfaff wrote:
> > Suppose you fix that; it should not be hard (just remove an "else"
> > keyword, I think). Then, second, the semantics implemented here will
> > surprise users, because if ofpacts are transl
On 13 July 2012 12:02, Ben Pfaff wrote:
> First, ofpacts_pull_openflow11_instructions() ignores
> OFPIT_WRITE_METADATA if OFPIT_APPLY_ACTIONS is specified. OF1.1 says,
> in contrast, that anything in OFPIT_APPLY_ACTIONS should be processed
> first, and then OFPIT_WRITE_METADATA. Both, in other w
On Thu, Jul 12, 2012 at 10:55:21AM +1200, Joe Stringer wrote:
> In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
> write to the metadata field. Internally it is represented using
> ofpact_metadata.
>
> We introduce NXAST_WRITE_METADATA to handle writing to the metadata
In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to
write to the metadata field. Internally it is represented using ofpact_metadata.
We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in
OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA.
Wh
