On 29.09.2016 02:52, Daniele Di Proietto wrote:
> Why are the variables uint8_t instead of bool?
>
> I think we shouldn't assume that converting to bool always returns 0 or 1,
> but the return value of smap_get_bool() is always 0 or 1 (as we always go
> through ! or !=). I would remove the ternar
Why are the variables uint8_t instead of bool?
I think we shouldn't assume that converting to bool always returns 0 or 1,
but the return value of smap_get_bool() is always 0 or 1 (as we always go
through ! or !=). I would remove the ternary operator
Thanks,
Daniele
2016-09-21 7:06 GMT-07:00 Ch
Hi Ilya,
Thank you for the patch. It looks fine for me.
Also I verified that the flow control is working fine with the modification.
Regards
_Sugesh
> -Original Message-
> From: Ilya Maximets [mailto:i.maxim...@samsung.com]
> Sent: Wednesday, September 21, 2016 11:39 AM
> To: dev@openv
On 21.09.2016 13:35, Ilya Maximets wrote:
> It is not necessary to touch the physical device each time, if the
> configuration has not been changed. Also, few style issues fixed.
>
> Thread-safety annotation added to 'dpdk_set_rxq_config()'. It was
> missed while previous refactoring of the flow c
It is not necessary to touch the physical device each time, if the
configuration has not been changed. Also, few style issues fixed.
Thread-safety annotation added to 'dpdk_set_rxq_config()'. It was
missed while previous refactoring of the flow control configuration.
Signed-off-by: Ilya Maximets
