Re: [ovs-dev] [PATCH v2] lib/classifier: Fix use of uninitialized memory.

2014-06-13 Thread Jarno Rajahalme
Thanks for the review! Pushed in two separate commits and the for statement restored and backported to branch-2.1 and branch-2.3. More comments below, Jarno On Jun 11, 2014, at 2:46 PM, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 03:06:22PM -0700, Jarno Rajahalme wrote: >> When reaching the

Re: [ovs-dev] [PATCH v2] lib/classifier: Fix use of uninitialized memory.

2014-06-11 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 03:06:22PM -0700, Jarno Rajahalme wrote: > When reaching the end of a prefix trie, we checked one bit off the end > to the intended data. However, since the trie node in that case has > NULLs for both edge links, this did not result in incorrect > functionality. > > Found

[ovs-dev] [PATCH v2] lib/classifier: Fix use of uninitialized memory.

2014-06-09 Thread Jarno Rajahalme
When reaching the end of a prefix trie, we checked one bit off the end to the intended data. However, since the trie node in that case has NULLs for both edge links, this did not result in incorrect functionality. Found via check-valgrind. Reported-by: Ben Pfaff Signed-off-by: Jarno Rajahalme