Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-07-13 Thread Alin Serdean
aybe it makes some sense to have it for further user. > > Alin. > > -Mesaj original- > De la: Eitan Eliahu [mailto:elia...@vmware.com] > Trimis: Thursday, June 25, 2015 6:01 PM > Către: Alin Serdean; Nithin Raju > Cc: Ben Pfaff; dev@openvswitch.org > Subiect: RE:

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-07-11 Thread Ben Pfaff
> > > > -Original Message- > > From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] > > Sent: Thursday, June 25, 2015 8:38 AM > > To: Eitan Eliahu; Nithin Raju > > Cc: Ben Pfaff; dev@openvswitch.org > > Subject: RE: [ovs-dev] [PATCH v2] dpif_probe_featur

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-07-10 Thread Gurucharan Shetty
Thanks Alin. > Eitan > > -Original Message- > From: Alin Serdean [mailto:aserd...@cloudbasesolutions.com] > Sent: Thursday, June 25, 2015 8:38 AM > To: Eitan Eliahu; Nithin Raju > Cc: Ben Pfaff; dev@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v2] dpif_probe_feature

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Eitan Eliahu
further user. Alin. -Mesaj original- De la: Eitan Eliahu [mailto:elia...@vmware.com] Trimis: Thursday, June 25, 2015 6:01 PM Către: Alin Serdean; Nithin Raju Cc: Ben Pfaff; dev@openvswitch.org Subiect: RE: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath Alin, We

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 01:47:16AM +, Alin Serdean wrote: > This patch disables features which are not currently supported > in the windows datapath. > > Unfortunately we have to do it in userspace because dpif_probe_feature is > not treated accordingly in the windows the datapath. > > I open

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Alin Serdean
Eliahu [mailto:elia...@vmware.com] Trimis: Thursday, June 25, 2015 6:01 PM Către: Alin Serdean; Nithin Raju Cc: Ben Pfaff; dev@openvswitch.org Subiect: RE: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath Alin, We just need to add: [OVS_FLOW_ATTR_PROBE

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Eitan Eliahu
: Thursday, June 25, 2015 7:30 AM To: Nithin Raju; Eitan Eliahu Cc: Ben Pfaff; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath Both are hacks IMO. We could respond to DPIF_FP_PROBE but I prefer to do it in userspace until we address the

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Alin Serdean
; Alin Serdean; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath > On Jun 24, 2015, at 12:57 PM, Eitan Eliahu wrote: > > > I'm wondering if we could fail this call in the datapath level by examining > the DPIF_FP_PR

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Nithin Raju
>> On Jun 18, 2015, at 6:47 PM, Alin Serdean >> wrote: >> >> This patch disables features which are not currently supported in the >> windows datapath. >> >> Unfortunately we have to do it in userspace because dpif_probe_feature >> is not treated accordingly in the windows the datapath. >>

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-25 Thread Nithin Raju
> On Jun 24, 2015, at 12:57 PM, Eitan Eliahu wrote: > > > I'm wondering if we could fail this call in the datapath level by examining > the DPIF_FP_PROBE bit in the flags. > If it is too hard we can still live with user mode code change. > Thanks, > Eitan That’s a good suggestion. We can go wi

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-24 Thread Eitan Eliahu
Sent: Wednesday, June 24, 2015 11:05 AM To: Alin Serdean Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath I guess this solution is OK with me for 2.4. Nithin (or anyone), do you agree that it's the best solution for now? On Fri, Ju

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-24 Thread Ben Pfaff
uld nuke > it later on. > > Alin. > > -Mesaj original- > De la: Nithin Raju [mailto:nit...@vmware.com] > Trimis: Friday, June 19, 2015 7:36 PM > Către: Alin Serdean > Cc: dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suport

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-19 Thread Alin Serdean
: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath hi Alin, Do you know what is required to complete the implementation of dpif_probe_feature() in the Windows datapath? Is it the flow validation logic? thanks, -- Nithin > On Jun 18, 2015, at 6:47 PM, Alin Serdean >

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-19 Thread Nithin Raju
hi Alin, Do you know what is required to complete the implementation of dpif_probe_feature() in the Windows datapath? Is it the flow validation logic? thanks, -- Nithin > On Jun 18, 2015, at 6:47 PM, Alin Serdean > wrote: > > This patch disables features which are not currently supported > i

[ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-18 Thread Alin Serdean
This patch disables features which are not currently supported in the windows datapath. Unfortunately we have to do it in userspace because dpif_probe_feature is not treated accordingly in the windows the datapath. I opened the issue to track the feature for later implementations: https://github.