Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2016-02-02 Thread Ilya Maximets
On 03.02.2016 03:32, Joe Stringer wrote: > On 29 January 2016 at 04:03, Ilya Maximets wrote: >> Hi. >> >> On 29.01.2016 04:02, Daniele Di Proietto wrote: >>> Hi guys, >>> >>> Sorry for resurrecting this thread, but I think we should reconsider >>> this patch at this point. >>> >>> Let me explain:

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2016-02-02 Thread Joe Stringer
On 29 January 2016 at 04:03, Ilya Maximets wrote: > Hi. > > On 29.01.2016 04:02, Daniele Di Proietto wrote: >> Hi guys, >> >> Sorry for resurrecting this thread, but I think we should reconsider >> this patch at this point. >> >> Let me explain: I'm still perfectly happy with the fix we applied, >

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2016-01-29 Thread Ilya Maximets
Hi. On 29.01.2016 04:02, Daniele Di Proietto wrote: > Hi guys, > > Sorry for resurrecting this thread, but I think we should reconsider > this patch at this point. > > Let me explain: I'm still perfectly happy with the fix we applied, > e4e74c3a2b9a("dpif-netdev: Purge all ukeys when reconfigure

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2016-01-28 Thread Daniele Di Proietto
Hi guys, Sorry for resurrecting this thread, but I think we should reconsider this patch at this point. Let me explain: I'm still perfectly happy with the fix we applied, e4e74c3a2b9a("dpif-netdev: Purge all ukeys when reconfigure pmd."), it is necessary to properly collect stats and it works per

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-10 Thread Alex Wang
Just post a proposed fix here, http://openvswitch.org/pipermail/dev/2015-August/058760.html Any comments are welcomed, On Mon, Aug 10, 2015 at 11:12 AM, Alex Wang wrote: > Hey IIya, > > Thx for the reply, Daniele helped me reproduced the issue offline and we > confirmed that this is not DPDK

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-10 Thread Alex Wang
Hey IIya, Thx for the reply, Daniele helped me reproduced the issue offline and we confirmed that this is not DPDK issue. However, this is also not a ufid issue either... Let me explain, First to clear up, with "packets from the same flow (or stream)", I mean packets with same src/dst MAC, IP,

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-10 Thread Ilya Maximets
Hello, Alex. I think, that this problem doesn't depend on dpdk. It is generic problem with ukeys. I found it while testing ODP-OVS from (Linaro Networking Group) without dpdk. IMHO, there must be opportunity to install ukeys for same flow by different pmd threads anyway, because they are reading

Re: [ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-07 Thread Alex Wang
Thx for reporting this, I worry this may not be an ovs issue, but to do with the dpdk driver... Here is my analysis, please correct me if wrong, When pmd threads are spawned, each of them will take ownership of port queues in a round robin fashion... In other words, each port queue will be read

[ovs-dev] [PATCH v2] dpif: allow adding ukeys for same flow by different pmds

2015-08-07 Thread Ilya Maximets
In multiqueue mode several pmd threads may process one port, but different queues. Flow doesn't depend on queue. So, while miss upcall processing, all threads (except first for that port) will receive error = ENOSPC due to ukey_install failure. Therefore they will not add the flow to flow_table an