Re: [ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-30 Thread Eitan Eliahu
[elia...@vmware.com] Sent: Friday, September 26, 2014 7:17 AM To: Samuel Ghinet; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] datapath-windows Event read handler Thanks Sam for the review. rc stands for Return Code and it holds the Boolean intermediate return code, returned from the NL

Re: [ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-30 Thread Samuel Ghinet
day, September 26, 2014 7:17 AM To: Samuel Ghinet; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] datapath-windows Event read handler Thanks Sam for the review. rc stands for Return Code and it holds the Boolean intermediate return code, returned from the NL functions. I removed the blank l

Re: [ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-25 Thread Eitan Eliahu
erLen != 0) { I see it shares some code with "case OVS_IOCTL_READ:" An idea would be to extract a common function of the two. But this is very minor. Regards, Sam Date: Thu, 25 Sep 2014 13:21:12 -0700 From: Eitan Eliahu To: dev@openvswitch.org S

Re: [ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-25 Thread Samuel Ghinet
shares some code with "case OVS_IOCTL_READ:" An idea would be to extract a common function of the two. But this is very minor. Regards, Sam Date: Thu, 25 Sep 2014 13:21:12 -0700 From: Eitan Eliahu To: dev@openvswitch.org Subject: [ovs-dev] [P

[ovs-dev] [PATCH v2] datapath-windows Event read handler

2014-09-25 Thread Eitan Eliahu
The Read event handler is executed when user mode issues a socket receive on an MC socket associated with the event queue. A new IOCTL READ command is used to differentiate between transaction based and packet miss sockets. An entry for the handler will be added once the Vport family implementation