Re: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL

2014-10-03 Thread Nithin Raju
On Oct 3, 2014, at 12:37 AM, Sorin Vinturis wrote: > Hi Eitan, > > The reason for pushing this patch was to optimize the code when obtaining a > lock. Thus I have set the flag parameters of NdisAcquireRWLockXXX() functions > to appropriate values, i.e. NDIS_RWL_AT_DISPATCH_LEVEL, each time

Re: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL

2014-10-03 Thread Sorin Vinturis
] Sent: Thursday, October 2, 2014 7:02 PM To: Sorin Vinturis; dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL Hi Sorin, Is it possible to assert on the IRQL before we assume DISPATCH_LEVEL: +NdisAcquireRWLockRead(gOvsSwitchContext

Re: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL

2014-10-02 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sorin Vinturis Trimis: Thursday, October 2, 2014 11:53 AM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL Acquiring a

Re: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL

2014-10-02 Thread Eitan Eliahu
e wrong IRQL. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sorin Vinturis Sent: Thursday, October 02, 2014 1:53 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL Acquiring a spin lock

Re: [ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL

2014-10-02 Thread Nithin Raju
On Oct 2, 2014, at 1:53 AM, Sorin Vinturis wrote: > Acquiring a spin lock raises the IRQL to DISPATCH_LEVEL. But > in many places of the code, while holding a spin lock, there > are useless checks for the current IRQL against DISPATCH_LEVEL. > Also, the dispatch flag is not correctly set when c

[ovs-dev] [PATCH v2] datapath-windows: Incorrect assumption of the IRQL

2014-10-02 Thread Sorin Vinturis
Acquiring a spin lock raises the IRQL to DISPATCH_LEVEL. But in many places of the code, while holding a spin lock, there are useless checks for the current IRQL against DISPATCH_LEVEL. Also, the dispatch flag is not correctly set when calling NdisAcquireRWLockXXX() functions, which causes an extra