Re: [ovs-dev] [PATCH v2] datapath: Optimize recirc action.

2014-08-08 Thread Pravin Shelar
I pushed it to master. Thanks. On Fri, Aug 8, 2014 at 12:41 PM, Andy Zhou wrote: > The rest of the patch also looks good. Thanks for making the changes. > > Acked-by: Andy Zhou > > On Thu, Aug 7, 2014 at 4:32 PM, Jarno Rajahalme wrote: >> I’ll let Andy review the recirculation part in the bott

Re: [ovs-dev] [PATCH v2] datapath: Optimize recirc action.

2014-08-08 Thread Andy Zhou
The rest of the patch also looks good. Thanks for making the changes. Acked-by: Andy Zhou On Thu, Aug 7, 2014 at 4:32 PM, Jarno Rajahalme wrote: > I’ll let Andy review the recirculation part in the bottom. For set actions: > > Acked-by: Jarno Rajahalme > > On Aug 7, 2014, at 3:46 PM, Pravin B

Re: [ovs-dev] [PATCH v2] datapath: Optimize recirc action.

2014-08-07 Thread Jarno Rajahalme
I’ll let Andy review the recirculation part in the bottom. For set actions: Acked-by: Jarno Rajahalme On Aug 7, 2014, at 3:46 PM, Pravin B Shelar wrote: > OVS need to flow key for flow lookup in recic action. OVS > does key extract in recic action. Most of cases we could > use OVS_CB packet ke

[ovs-dev] [PATCH v2] datapath: Optimize recirc action.

2014-08-07 Thread Pravin B Shelar
OVS need to flow key for flow lookup in recic action. OVS does key extract in recic action. Most of cases we could use OVS_CB packet key directly and can avoid packet flow key extract. SET action we can update flow-key along with packet to keep it consistent. But there are some action like MPLS pop