Re: [ovs-dev] [PATCH v2] datapath: Fully initialize datapath before local port.

2011-09-19 Thread Jesse Gross
On Fri, Sep 16, 2011 at 1:08 PM, Ben Pfaff wrote: > On Fri, Sep 16, 2011 at 01:02:19PM -0700, Jesse Gross wrote: >> On Fri, Sep 16, 2011 at 9:42 AM, Ben Pfaff wrote: >> > 'dp_ifindex' is never used in the fast path, only in Netlink handling >> > and in the slow path that sends packets that miss u

Re: [ovs-dev] [PATCH v2] datapath: Fully initialize datapath before local port.

2011-09-16 Thread Ben Pfaff
On Fri, Sep 16, 2011 at 01:02:19PM -0700, Jesse Gross wrote: > On Fri, Sep 16, 2011 at 9:42 AM, Ben Pfaff wrote: > > 'dp_ifindex' is never used in the fast path, only in Netlink handling > > and in the slow path that sends packets that miss up to userspace. ??We > > could get rid of dp_ifindex, re

Re: [ovs-dev] [PATCH v2] datapath: Fully initialize datapath before local port.

2011-09-16 Thread Jesse Gross
On Fri, Sep 16, 2011 at 9:42 AM, Ben Pfaff wrote: > On Thu, Sep 15, 2011 at 05:50:16PM -0700, Jesse Gross wrote: >> It's possible to start receiving packets on a datapath as soon as >> the internal device is created.  It's therefore important that the >> datapath be fully initialized before this,

Re: [ovs-dev] [PATCH v2] datapath: Fully initialize datapath before local port.

2011-09-16 Thread Ben Pfaff
On Thu, Sep 15, 2011 at 05:50:16PM -0700, Jesse Gross wrote: > It's possible to start receiving packets on a datapath as soon as > the internal device is created. It's therefore important that the > datapath be fully initialized before this, which it currently isn't. > In particularly, the fact th

[ovs-dev] [PATCH v2] datapath: Fully initialize datapath before local port.

2011-09-15 Thread Jesse Gross
It's possible to start receiving packets on a datapath as soon as the internal device is created. It's therefore important that the datapath be fully initialized before this, which it currently isn't. In particularly, the fact that dp->stats_percpu is not yet set is potentially fatal. In addition