Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-09 Thread Simon Horman
I would really appreciate some feedback from people on netdev on the issues described at the bottom of this thread. On Fri, Apr 05, 2013 at 10:07:38AM +0900, Simon Horman wrote: > On Thu, Apr 04, 2013 at 10:20:47AM -0700, Jesse Gross wrote: > > On Wed, Apr 3, 2013 at 5:55 PM, Simon Horman wrote:

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-04 Thread Simon Horman
On Thu, Apr 04, 2013 at 10:20:47AM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 5:55 PM, Simon Horman wrote: > > On Wed, Apr 03, 2013 at 05:44:17PM -0700, Jesse Gross wrote: > >> On Wed, Apr 3, 2013 at 5:28 PM, Simon Horman wrote: > >> > On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-04 Thread Jesse Gross
On Wed, Apr 3, 2013 at 5:55 PM, Simon Horman wrote: > On Wed, Apr 03, 2013 at 05:44:17PM -0700, Jesse Gross wrote: >> On Wed, Apr 3, 2013 at 5:28 PM, Simon Horman wrote: >> > On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: >> >> On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: >>

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 05:44:17PM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 5:28 PM, Simon Horman wrote: > > On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: > >> On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: > >> > In the case where a non-MPLS packet is recieved and a

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 5:28 PM, Simon Horman wrote: > On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: >> On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: >> > In the case where a non-MPLS packet is recieved and an MPLS stack is >> > added it may well be the case that the original

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: > > In the case where a non-MPLS packet is recieved and an MPLS stack is > > added it may well be the case that the original skb is GSO but the > > NIC used for transmit does not supp

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: > In the case where a non-MPLS packet is recieved and an MPLS stack is > added it may well be the case that the original skb is GSO but the > NIC used for transmit does not support GSO of MPLS packets. > > The aim of this code is to provide GSO i

[ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
In the case where a non-MPLS packet is recieved and an MPLS stack is added it may well be the case that the original skb is GSO but the NIC used for transmit does not support GSO of MPLS packets. The aim of this code is to provide GSO in software for MPLS packets whose skbs are GSO. When an imple