Re: [ovs-dev] [PATCH v2] Handle NBLs with multiple NBs

2014-09-24 Thread Samuel Ghinet
Hi Nithin, > Minor: the commit message seems a little inaccurate. One suggestion I have is > we should probably say something like: Fixed > Suggestion: you can annotate the github issue #: > https://github.com/openvswitch/ovs-issues/issues/2 (If I am not wrong). I'm not sure how you meant. I real

Re: [ovs-dev] [PATCH v2] Handle NBLs with multiple NBs

2014-09-23 Thread Nithin Raju
hi Samuel, Thanks for the re-spin. I'm afraid, there'll have to be another iteration. I see a refCounting issue when origNbl->FirstNetBuffer->Next != NULL. I have noted that down in the code. Other comments are very minor. Thanks again for working on this. I'll be on IRC if you want to chat. t

Re: [ovs-dev] [PATCH v2] Handle NBLs with multiple NBs

2014-09-23 Thread Eitan Eliahu
Sam, can you please runs VXLAN traffic while the DriverVerifier is enabled on the driver? If uninstallation is successful after the test we should be good to go. Thank you, Eitan -Original Message- From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com] Sent: Tuesday, September 23, 2

[ovs-dev] [PATCH v2] Handle NBLs with multiple NBs

2014-09-23 Thread Samuel Ghinet
All NET_BUFFERs of a NET_BUFFER_LIST must go through the pipeline: extract, find flow, execute. Previously, only the first NET_BUFFER of a NET_BUFFER_LIST was going through this pipeline, which was erroneous. OvsPartialCopyToMultipleNBLs is used to make each NET_BUFFER have its own NET_BUFFER_LIST