Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jesse Gross
On Thu, Dec 13, 2012 at 5:39 AM, Jarno Rajahalme wrote: > > On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: >> In any case, flags should be converted between userspace and kernel. >> The same set of flags happen to be defined now with the same values >> but it shouldn't be assumed that is the c

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jesse Gross
On Thu, Dec 13, 2012 at 2:08 AM, Jarno Rajahalme wrote: > On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: >> On Wed, Dec 12, 2012 at 6:34 AM, Jarno Rajahalme >> wrote: >>> This version adds odp-level support for tunnel metadata. >>> >>> Currently it seems the datapath expects userspace to spec

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jarno Rajahalme
On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: > In any case, flags should be converted between userspace and kernel. > The same set of flags happen to be defined now with the same values > but it shouldn't be assumed that is the case. In particular, if there > are different versions of users

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-13 Thread Jarno Rajahalme
On Dec 12, 2012, at 18:23 , ext Jesse Gross wrote: > On Wed, Dec 12, 2012 at 6:34 AM, Jarno Rajahalme > wrote: >> This version adds odp-level support for tunnel metadata. >> >> Currently it seems the datapath expects userspace to specify all the >> tunnel fields, or none of them. IMO, it would b

Re: [ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-12 Thread Jesse Gross
On Wed, Dec 12, 2012 at 6:34 AM, Jarno Rajahalme wrote: > This version adds odp-level support for tunnel metadata. > > Currently it seems the datapath expects userspace to specify all the > tunnel fields, or none of them. IMO, it would be better to use of > configured values as defaults, allowing

[ovs-dev] [PATCH v2] Add experimental support for TUNNEL SRC/DST.

2012-12-12 Thread Jarno Rajahalme
This version adds odp-level support for tunnel metadata. Currently it seems the datapath expects userspace to specify all the tunnel fields, or none of them. IMO, it would be better to use of configured values as defaults, allowing flow entries to provide only some of the fields (e.g., tun_dst).