Re: [ovs-dev] [PATCH v2] Add Docker integration for OVN.

2015-11-11 Thread Gurucharan Shetty
> I was expecting something more like: > > ovn_nbctl("lswitch-add", network, "--", "set", "Logical_Switch", > network, "external_ids:subnet=" + subnet, > "external_ids:gateway_ip=" + gateway_ip) > > and then change ovn_nbctl to take argv instead of a string to break

Re: [ovs-dev] [PATCH v2] Add Docker integration for OVN.

2015-11-10 Thread Ben Pfaff
On Tue, Nov 10, 2015 at 02:45:05PM -0800, Gurucharan Shetty wrote: > > In the Python code, I wonder whether there are any concerns about > > malicious input. I mean, what if someone names a subnet "-- > > emer-reset", for example (or similar)? Would that delete basically the > > whole OVS databas

Re: [ovs-dev] [PATCH v2] Add Docker integration for OVN.

2015-11-10 Thread Gurucharan Shetty
> Thanks for doing this! I have a few comments, see below. Thank you for the review! > > I guess that $IP should be $HOST_IP here. True. I corrected it. > I think that the paragraph above means that you have to do this on one > machine selected from your hypervisors. But "on any machine...whe

Re: [ovs-dev] [PATCH v2] Add Docker integration for OVN.

2015-11-09 Thread Ben Pfaff
On Mon, Oct 19, 2015 at 02:52:25PM -0700, Gurucharan Shetty wrote: > Docker removed 'experimental' tag for their multi-host > networking constructs last week and did a code freeze for > Docker 1.9. > > This commit adds two drivers for OVN integration > with Docker. The first driver is a pure overl

Re: [ovs-dev] [PATCH v2] Add Docker integration for OVN.

2015-10-19 Thread Murali R
Thanks Gurucharan, for this driver. I will try this pure overlay driver in my next iteration in Nov adding l3 without neutron. For docker 1.8 at this time I am leveraging neutron api for most network mgmt and some flask based for api and some shell at this time for a next week target (not openstack

[ovs-dev] [PATCH v2] Add Docker integration for OVN.

2015-10-19 Thread Gurucharan Shetty
Docker removed 'experimental' tag for their multi-host networking constructs last week and did a code freeze for Docker 1.9. This commit adds two drivers for OVN integration with Docker. The first driver is a pure overlay driver that does not need OpenStack integration. The second driver needs OVN