Re: [ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

2015-04-29 Thread Ben Pfaff
On Wed, Apr 29, 2015 at 06:19:48PM -0700, Justin Pettit wrote: > > > On Apr 29, 2015, at 10:12 AM, Ben Pfaff wrote: > > > > When I wrote expr_to_flows() originally, I assumed that the caller could > > simply add an appropriate conj_id=X flow for each of the conjunctive > > matches. I forgot tha

Re: [ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

2015-04-29 Thread Justin Pettit
> On Apr 29, 2015, at 10:12 AM, Ben Pfaff wrote: > > When I wrote expr_to_flows() originally, I assumed that the caller could > simply add an appropriate conj_id=X flow for each of the conjunctive > matches. I forgot that the conj_id=X flows also need to include > prerequisites for actions, e.g

[ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

2015-04-29 Thread Ben Pfaff
When I wrote expr_to_flows() originally, I assumed that the caller could simply add an appropriate conj_id=X flow for each of the conjunctive matches. I forgot that the conj_id=X flows also need to include prerequisites for actions, e.g. if the OpenFlow actions manipulate TCP fields, then the conj