Re: [ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-12-12 Thread Jesse Gross
On Wed, Dec 12, 2012 at 10:38 AM, Tom Herbert wrote: >> At an implementation level, the goal is definitely to share as much >> code as possible. Some of that was obviously done to support this >> patch and I'm sure there are more areas where it could be taken >> further. >> >> At a more conceptua

Re: [ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-12-12 Thread Tom Herbert
> At an implementation level, the goal is definitely to share as much > code as possible. Some of that was obviously done to support this > patch and I'm sure there are more areas where it could be taken > further. > > At a more conceptual level we've explored this path a number of times > and it'

Re: [ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-12-12 Thread Jesse Gross
On Tue, Dec 11, 2012 at 7:14 PM, Tom Herbert wrote: >> This patch adds ipv6 set action functionality. It allows to change >> traffic class, flow label, hop-limit, ipv6 source and destination >> address fields. >> > I have to wonder about these patches and the underlying design > direction. Aren't

Re: [ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-12-12 Thread Jamal Hadi Salim
On 12-12-11 10:14 PM, Tom Herbert wrote: This patch adds ipv6 set action functionality. It allows to change traffic class, flow label, hop-limit, ipv6 source and destination address fields. I have to wonder about these patches and the underlying design direction. Aren't these sort of things an

Re: [ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-12-11 Thread Tom Herbert
> This patch adds ipv6 set action functionality. It allows to change > traffic class, flow label, hop-limit, ipv6 source and destination > address fields. > I have to wonder about these patches and the underlying design direction. Aren't these sort of things and more already implemented by IPtable

[ovs-dev] [PATCH net-next 4/7] openvswitch: add ipv6 'set' action

2012-11-29 Thread Jesse Gross
From: Ansis Atteka This patch adds ipv6 set action functionality. It allows to change traffic class, flow label, hop-limit, ipv6 source and destination address fields. Signed-off-by: Ansis Atteka Signed-off-by: Jesse Gross --- net/openvswitch/actions.c | 93