Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-27 Thread jamal
On Sat, 2011-11-26 at 23:17 -0800, Justin Pettit wrote: > > You're right--calling tc directly through system() is kind of ugly. > That code was written a *long* time ago when we wanted a quick QoS story. > As you mentioned, we use netlink to configure traffic shaping, so we have > all the pieces

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-26 Thread Justin Pettit
On Nov 24, 2011, at 5:25 AM, jamal wrote: > The most basic IMO is to use netlink if you are doing > it from a programmatic interface. You seem to be doing that > already for other items (eg HTB) in the setup. There are > a few libraries out there you could use but i realize > that they may not mat

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-24 Thread jamal
Hi Justin, I apologize, I did not intend to demean your work. There are lots of clever ideas in there and you may have wanted to put out something in a short period out there. The most basic IMO is to use netlink if you are doing it from a programmatic interface. You seem to be doing that already

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-23 Thread Justin Pettit
On Nov 22, 2011, at 5:45 PM, Jamal Hadi Salim wrote: > BTW, you _are using some of the actions_ already (the policer for > example to do rate control; no disrespect intended but in a terrible > way). Hi, Jamal. I did the initial implementation of the rate control in Open vSwitch. Can you hel

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread Chris Wright
* John Fastabend (john.r.fastab...@intel.com) wrote: > He is pushing and popping entire tags off 802.1Q for now but > you can easily imagine MPLS tags and all sorts of other things > people will _need_. Right, already doing some generic encap/decap for tunnelling. > Do we want tc and likely the s

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread Jamal Hadi Salim
On Tue, 2011-11-22 at 18:30 -0800, John Fastabend wrote: > He is pushing and popping entire tags off 802.1Q for now but > you can easily imagine MPLS tags and all sorts of other things > people will _need_. Lots of packet munging already happening with actions. We can pedit/nat/iptables/checksum

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread John Fastabend
On 11/22/2011 5:45 PM, Jamal Hadi Salim wrote: > On Tue, 2011-11-22 at 15:11 -0800, Jesse Gross wrote: > > >> As you mention, one of the biggest benefits of Open vSwitch is how >> simple the kernel portions are (it's less than 6000 lines). > > I said that was the reason _you_ were using to jus

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread Jamal Hadi Salim
On Tue, 2011-11-22 at 15:11 -0800, Jesse Gross wrote: > As you mention, one of the biggest benefits of Open vSwitch is how > simple the kernel portions are (it's less than 6000 lines). I said that was the reason _you_ were using to justify things and i argue that is not accurate. You will be a

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread David Miller
From: Jesse Gross Date: Tue, 22 Nov 2011 17:34:57 -0800 > On Tue, Nov 22, 2011 at 3:19 PM, David Miller wrote: >> From: Jesse Gross >> Date: Tue, 22 Nov 2011 15:11:33 -0800 >> >>> As you mention, one of the biggest benefits of Open vSwitch is how >>> simple the kernel portions are (it's less th

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread Jesse Gross
On Tue, Nov 22, 2011 at 3:19 PM, David Miller wrote: > From: Jesse Gross > Date: Tue, 22 Nov 2011 15:11:33 -0800 > >> As you mention, one of the biggest benefits of Open vSwitch is how >> simple the kernel portions are (it's less than 6000 lines).  It's >> existed as an out-of-tree project for se

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread David Miller
From: Jesse Gross Date: Tue, 22 Nov 2011 15:11:33 -0800 > As you mention, one of the biggest benefits of Open vSwitch is how > simple the kernel portions are (it's less than 6000 lines). It's > existed as an out-of-tree project for several years now so it's > actually fairly mature already and u

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread Jesse Gross
On Mon, Nov 21, 2011 at 4:29 AM, jamal wrote: > > Reading your website - it seems you indicate the code to be portable > across other platforms. That is a noble reason - but i dont think > it is good enough a reason in my opinion to have your own > replicated infrastructure on top of Linux. It's

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-22 Thread Jesse Gross
On Mon, Nov 21, 2011 at 4:20 AM, jamal wrote: > On Fri, 2011-11-18 at 15:12 -0800, Jesse Gross wrote: >> Open vSwitch is a multilayer Ethernet switch targeted at virtualized >> environments.  In addition to supporting a variety of features >> expected in a traditional hardware switch, it enables f

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-21 Thread jamal
Reading your website - it seems you indicate the code to be portable across other platforms. That is a noble reason - but i dont think it is good enough a reason in my opinion to have your own replicated infrastructure on top of Linux. cheers, jamal On Mon, 2011-11-21 at 07:20 -0500, jamal wrot

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-21 Thread jamal
On Fri, 2011-11-18 at 15:12 -0800, Jesse Gross wrote: > Open vSwitch is a multilayer Ethernet switch targeted at virtualized > environments. In addition to supporting a variety of features > expected in a traditional hardware switch, it enables fine-grained > programmatic extension and flow-based

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-19 Thread John Fastabend
On 11/19/2011 3:06 PM, Jesse Gross wrote: > On Fri, Nov 18, 2011 at 9:30 PM, John Fastabend > wrote: >> On 11/18/2011 3:12 PM, Jesse Gross wrote: >>> + */ >>> +enum ovs_frag_type { >>> + OVS_FRAG_TYPE_NONE, >>> + OVS_FRAG_TYPE_FIRST, >>> + OVS_FRAG_TYPE_LATER, >>> + __OVS_F

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-19 Thread Jesse Gross
On Fri, Nov 18, 2011 at 9:30 PM, John Fastabend wrote: > On 11/18/2011 3:12 PM, Jesse Gross wrote: >> + */ >> +enum ovs_frag_type { >> +       OVS_FRAG_TYPE_NONE, >> +       OVS_FRAG_TYPE_FIRST, >> +       OVS_FRAG_TYPE_LATER, >> +       __OVS_FRAG_TYPE_MAX >> +}; >> + >> +#define OVS_FRAG_TYPE_MA

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-19 Thread Jesse Gross
On Fri, Nov 18, 2011 at 5:37 PM, David Miller wrote: > From: Stephen Hemminger > Date: Fri, 18 Nov 2011 17:09:17 -0800 (PST) > >> >>> On Fri, Nov 18, 2011 at 3:23 PM, Stephen Hemminger >>> wrote: >>> > On Fri, 18 Nov 2011 15:12:18 -0800 >>> > Jesse Gross wrote: >>> > >>> >> +             write_

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-18 Thread John Fastabend
On 11/18/2011 3:12 PM, Jesse Gross wrote: > Open vSwitch is a multilayer Ethernet switch targeted at virtualized > environments. In addition to supporting a variety of features > expected in a traditional hardware switch, it enables fine-grained > programmatic extension and flow-based control of t

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-18 Thread David Miller
From: Stephen Hemminger Date: Fri, 18 Nov 2011 17:09:17 -0800 (PST) > >> On Fri, Nov 18, 2011 at 3:23 PM, Stephen Hemminger >> wrote: >> > On Fri, 18 Nov 2011 15:12:18 -0800 >> > Jesse Gross wrote: >> > >> >> +             write_seqcount_begin(&stats->seqlock); >> >> +             stats->tx_pa

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-18 Thread Stephen Hemminger
> On Fri, Nov 18, 2011 at 3:23 PM, Stephen Hemminger > wrote: > > On Fri, 18 Nov 2011 15:12:18 -0800 > > Jesse Gross wrote: > > > >> +             write_seqcount_begin(&stats->seqlock); > >> +             stats->tx_packets++; > >> +             stats->tx_bytes += sent; > >> +             write_s

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-18 Thread Jesse Gross
On Fri, Nov 18, 2011 at 3:23 PM, Stephen Hemminger wrote: > On Fri, 18 Nov 2011 15:12:18 -0800 > Jesse Gross wrote: > >> +             write_seqcount_begin(&stats->seqlock); >> +             stats->tx_packets++; >> +             stats->tx_bytes += sent; >> +             write_seqcount_end(&stats-

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-18 Thread Stephen Hemminger
On Fri, 18 Nov 2011 15:12:18 -0800 Jesse Gross wrote: > + write_seqcount_begin(&stats->seqlock); > + stats->tx_packets++; > + stats->tx_bytes += sent; > + write_seqcount_end(&stats->seqlock); There is a u64_stats_sync set of macros for this. It has