Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-11 Thread Alexei Starovoitov
On Fri, Oct 11, 2013 at 3:02 PM, Jesse Gross wrote: > On Fri, Oct 11, 2013 at 1:03 PM, Alexei Starovoitov wrote: >> On Fri, Oct 11, 2013 at 11:11 AM, Jesse Gross wrote: >>> On Thu, Oct 10, 2013 at 9:48 PM, Alexei Starovoitov >>> wrote: On Thu, Oct 10, 2013 at 8:56 PM, Jesse Gross wrote:

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-11 Thread Jesse Gross
On Fri, Oct 11, 2013 at 1:03 PM, Alexei Starovoitov wrote: > On Fri, Oct 11, 2013 at 11:11 AM, Jesse Gross wrote: >> On Thu, Oct 10, 2013 at 9:48 PM, Alexei Starovoitov >> wrote: >>> On Thu, Oct 10, 2013 at 8:56 PM, Jesse Gross wrote: However, the check dev->reg_state in netdev_destroy()

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-11 Thread Alexei Starovoitov
On Fri, Oct 11, 2013 at 11:11 AM, Jesse Gross wrote: > On Thu, Oct 10, 2013 at 9:48 PM, Alexei Starovoitov wrote: >> On Thu, Oct 10, 2013 at 8:56 PM, Jesse Gross wrote: >>> However, the check dev->reg_state in netdev_destroy() looks racy to >>> me, as it could already be in NETREG_UNREGISTERED e

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-11 Thread Jesse Gross
On Thu, Oct 10, 2013 at 9:48 PM, Alexei Starovoitov wrote: > On Thu, Oct 10, 2013 at 8:56 PM, Jesse Gross wrote: >> However, the check dev->reg_state in netdev_destroy() looks racy to >> me, as it could already be in NETREG_UNREGISTERED even if we already >> processed this device. > > you mean th

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-10 Thread Alexei Starovoitov
On Thu, Oct 10, 2013 at 8:56 PM, Jesse Gross wrote: > On Thu, Oct 10, 2013 at 5:47 PM, Alexei Starovoitov wrote: >> On Thu, Oct 10, 2013 at 3:38 PM, Pravin Shelar wrote: >>> On Thu, Oct 10, 2013 at 1:48 PM, Alexei Starovoitov >>> wrote: On Thu, Oct 10, 2013 at 11:21 AM, Pravin Shelar wro

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-10 Thread Jesse Gross
On Thu, Oct 10, 2013 at 5:47 PM, Alexei Starovoitov wrote: > On Thu, Oct 10, 2013 at 3:38 PM, Pravin Shelar wrote: >> On Thu, Oct 10, 2013 at 1:48 PM, Alexei Starovoitov >> wrote: >>> On Thu, Oct 10, 2013 at 11:21 AM, Pravin Shelar wrote: On Wed, Oct 9, 2013 at 11:26 PM, Alexei Starovoito

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-10 Thread Alexei Starovoitov
On Thu, Oct 10, 2013 at 3:38 PM, Pravin Shelar wrote: > On Thu, Oct 10, 2013 at 1:48 PM, Alexei Starovoitov wrote: >> On Thu, Oct 10, 2013 at 11:21 AM, Pravin Shelar wrote: >>> On Wed, Oct 9, 2013 at 11:26 PM, Alexei Starovoitov >>> wrote: On Wed, Oct 9, 2013 at 11:07 PM, Pravin Shelar w

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-10 Thread Pravin Shelar
On Thu, Oct 10, 2013 at 1:48 PM, Alexei Starovoitov wrote: > On Thu, Oct 10, 2013 at 11:21 AM, Pravin Shelar wrote: >> On Wed, Oct 9, 2013 at 11:26 PM, Alexei Starovoitov >> wrote: >>> On Wed, Oct 9, 2013 at 11:07 PM, Pravin Shelar wrote: On Wed, Oct 9, 2013 at 9:11 PM, Alexei Starovoitov

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-10 Thread Alexei Starovoitov
On Thu, Oct 10, 2013 at 11:21 AM, Pravin Shelar wrote: > On Wed, Oct 9, 2013 at 11:26 PM, Alexei Starovoitov wrote: >> On Wed, Oct 9, 2013 at 11:07 PM, Pravin Shelar wrote: >>> On Wed, Oct 9, 2013 at 9:11 PM, Alexei Starovoitov >>> wrote: On Wed, Oct 9, 2013 at 8:02 PM, Pravin Shelar wro

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-10 Thread Pravin Shelar
On Wed, Oct 9, 2013 at 11:26 PM, Alexei Starovoitov wrote: > On Wed, Oct 9, 2013 at 11:07 PM, Pravin Shelar wrote: >> On Wed, Oct 9, 2013 at 9:11 PM, Alexei Starovoitov wrote: >>> On Wed, Oct 9, 2013 at 8:02 PM, Pravin Shelar wrote: On Tue, Oct 8, 2013 at 8:07 PM, Alexei Starovoitov

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-09 Thread Alexei Starovoitov
On Wed, Oct 9, 2013 at 11:07 PM, Pravin Shelar wrote: > On Wed, Oct 9, 2013 at 9:11 PM, Alexei Starovoitov wrote: >> On Wed, Oct 9, 2013 at 8:02 PM, Pravin Shelar wrote: >>> On Tue, Oct 8, 2013 at 8:07 PM, Alexei Starovoitov >>> wrote: The combination of two commits commit 8e4e1

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-09 Thread Pravin Shelar
On Wed, Oct 9, 2013 at 9:11 PM, Alexei Starovoitov wrote: > On Wed, Oct 9, 2013 at 8:02 PM, Pravin Shelar wrote: >> On Tue, Oct 8, 2013 at 8:07 PM, Alexei Starovoitov wrote: >>> The combination of two commits >>> >>> commit 8e4e1713e4 >>> ("openvswitch: Simplify datapath locking.") >>> >>> and >

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-09 Thread Alexei Starovoitov
On Wed, Oct 9, 2013 at 8:02 PM, Pravin Shelar wrote: > On Tue, Oct 8, 2013 at 8:07 PM, Alexei Starovoitov wrote: >> The combination of two commits >> >> commit 8e4e1713e4 >> ("openvswitch: Simplify datapath locking.") >> >> and >> >> commit 2537b4dd0a >> ("openvswitch:: link upper device for port

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-09 Thread Pravin Shelar
On Tue, Oct 8, 2013 at 8:07 PM, Alexei Starovoitov wrote: > The combination of two commits > > commit 8e4e1713e4 > ("openvswitch: Simplify datapath locking.") > > and > > commit 2537b4dd0a > ("openvswitch:: link upper device for port devices") > > introduced a bug where upper_dev wasn't unlinked u

Re: [ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-09 Thread Jesse Gross
On Tue, Oct 8, 2013 at 8:07 PM, Alexei Starovoitov wrote: > The combination of two commits > > commit 8e4e1713e4 > ("openvswitch: Simplify datapath locking.") > > and > > commit 2537b4dd0a > ("openvswitch:: link upper device for port devices") > > introduced a bug where upper_dev wasn't unlinked u

[ovs-dev] [PATCH net-next] openvswitch: fix vport-netdev unregister

2013-10-08 Thread Alexei Starovoitov
The combination of two commits commit 8e4e1713e4 ("openvswitch: Simplify datapath locking.") and commit 2537b4dd0a ("openvswitch:: link upper device for port devices") introduced a bug where upper_dev wasn't unlinked upon netdev_unregister notification The following steps: modprobe openvswi