Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread David Miller
From: Flavio Leitner Date: Wed, 27 May 2015 10:24:14 -0300 > On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: >> On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: >> > OVS interface for generic networking device operation looks odd. have >> > you considered adding new device ioct

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread Flavio Leitner
On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: > On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: > > OVS interface for generic networking device operation looks odd. have > > you considered adding new device ioctl to do this? > > New ioctls for networking configuration are gen

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread Jiri Benc
On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: > OVS interface for generic networking device operation looks odd. have > you considered adding new device ioctl to do this? New ioctls for networking configuration are generally not allowed. The preferred way to configure networking is netl

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-26 Thread Pravin Shelar
On Tue, May 26, 2015 at 10:38 AM, Jiri Benc wrote: > Currently, openvswitch tries to disable LRO from the user space. This does > not work correctly when the device added is a vlan interface, though. > Instead of dealing with possibly complex stacked cross name space relations > in the user space,

[ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-26 Thread Jiri Benc
Currently, openvswitch tries to disable LRO from the user space. This does not work correctly when the device added is a vlan interface, though. Instead of dealing with possibly complex stacked cross name space relations in the user space, do the same as bridging does and call dev_disable_lro in th