Re: [ovs-dev] [PATCH net] geneve: Refine MTU limit

2016-02-18 Thread David Wragg
Jesse Gross writes: > In addition to Tom's comment about taking into account > dev->hard_header_len, can you please not include > GENEVE_MAX_OPTIONS_LEN in the MTU calculation based on the discussion > on the other thread? Otherwise, you are excluding some potentially > valid configurations. Addr

Re: [ovs-dev] [PATCH net] geneve: Refine MTU limit

2016-02-16 Thread Jesse Gross
On Tue, Feb 16, 2016 at 4:33 AM, David Wragg wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 028e387..f57f9bc 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -37,6 +37,9 @@ MODULE_PARM_DESC(log_ecn_error, "Log packets received with > corrupted ECN")

[ovs-dev] [PATCH net] geneve: Refine MTU limit

2016-02-16 Thread David Wragg
While GENEVE allows variable length options, the maximum length of the options is 63 * 4 bytes. So we can reasonably set an MTU limit other than IP_MAX_MTU, as the other tunnel devices do. Signed-off-by: David Wragg --- drivers/net/geneve.c | 11 ++- 1 file changed, 6 insertions(+), 5 d