Re: [ovs-dev] [PATCH V5 2/2] bridge: Refactor the 'Instant' stats logic.

2014-04-27 Thread Alex Wang
On Sun, Apr 27, 2014 at 6:03 PM, Joe Stringer wrote: > This could be shifted to the top of the file, next to connectivity_seqno. > Not sure if you want to add a comment like the previous "instant stats" > description above it too. I think it's useful to have the context that > these are treated se

Re: [ovs-dev] [PATCH V5 2/2] bridge: Refactor the 'Instant' stats logic.

2014-04-27 Thread Joe Stringer
On 25 April 2014 11:55, Alex Wang wrote: > > +/* Current status database transaction, NULL if there is no ongoing > + * transaction. */ > +static struct ovsdb_idl_txn *status_txn; > + > +/* When the status update commit returns "TXN_INCOMPLETE", should > register a > + * timeout in "STATUS_CHECK_A

[ovs-dev] [PATCH V5 2/2] bridge: Refactor the 'Instant' stats logic.

2014-04-24 Thread Alex Wang
This commit refactors the 'Instant' stats related logic in bridge.c by moving it into bridge_run(). This change brings the following effects: 1. bridge.c will wait on the global connectivity sequence number when there is no pending instant stats transaction. and the main thread will no lon