Re: [ovs-dev] [PATCH V3] ofproto-dpif-monitor: Fix deadlock.

2014-05-02 Thread Alex Wang
Thanks for the review, Tested again and applied to master, branch-2.2 On Thu, May 1, 2014 at 8:36 AM, Ben Pfaff wrote: > On Tue, Apr 29, 2014 at 11:06:29AM -0700, Alex Wang wrote: > > Commit 6b59b543 (ovs-thread: Use fair (but nonrecursive) > > rwlocks on glibc.) changed the rwlocks to nonrecu

Re: [ovs-dev] [PATCH V3] ofproto-dpif-monitor: Fix deadlock.

2014-05-01 Thread Ben Pfaff
On Tue, Apr 29, 2014 at 11:06:29AM -0700, Alex Wang wrote: > Commit 6b59b543 (ovs-thread: Use fair (but nonrecursive) > rwlocks on glibc.) changed the rwlocks to nonrecursive, > writer-biased lock. It also made the following deadlock > possible. > > Assume BFD is used on both end of a link. Cons

[ovs-dev] [PATCH V3] ofproto-dpif-monitor: Fix deadlock.

2014-04-29 Thread Alex Wang
Commit 6b59b543 (ovs-thread: Use fair (but nonrecursive) rwlocks on glibc.) changed the rwlocks to nonrecursive, writer-biased lock. It also made the following deadlock possible. Assume BFD is used on both end of a link. Consider the following events: 1. Handler at one end received the BFD contr