On Thu, Jul 11, 2013 at 12:44:50PM +0900, YAMAMOTO Takashi wrote:
> > On Tue, Jul 09, 2013 at 05:18:34PM +0900, YAMAMOTO Takashi wrote:
> >> hi,
> >>
> >> > @@ -708,9 +711,7 @@ dpif_netdev_flow_from_nlattrs(const struct nlattr
> >> > *key, uint32_t key_len,
> >> > return EINVAL;
> >> >
hi,
> On Tue, Jul 09, 2013 at 05:18:34PM +0900, YAMAMOTO Takashi wrote:
>> hi,
>>
>> > @@ -708,9 +711,7 @@ dpif_netdev_flow_from_nlattrs(const struct nlattr
>> > *key, uint32_t key_len,
>> > return EINVAL;
>> > }
>> >
>> > -if (flow->in_port < OFPP_MAX
>> > -? flow->i
Sorry Yamamoto and thanks Ben,
Please ignore my previous reply.
On Tue, Jul 9, 2013 at 9:24 AM, Ben Pfaff wrote:
> On Tue, Jul 09, 2013 at 05:18:34PM +0900, YAMAMOTO Takashi wrote:
> > hi,
> >
> > > @@ -708,9 +711,7 @@ dpif_netdev_flow_from_nlattrs(const struct nlattr
> *key, uint32_t key_len,
On Tue, Jul 09, 2013 at 05:18:34PM +0900, YAMAMOTO Takashi wrote:
> hi,
>
> > @@ -708,9 +711,7 @@ dpif_netdev_flow_from_nlattrs(const struct nlattr *key,
> > uint32_t key_len,
> > return EINVAL;
> > }
> >
> > -if (flow->in_port < OFPP_MAX
> > -? flow->in_port >= MAX_PO
hi,
> @@ -708,9 +711,7 @@ dpif_netdev_flow_from_nlattrs(const struct nlattr *key,
> uint32_t key_len,
> return EINVAL;
> }
>
> -if (flow->in_port < OFPP_MAX
> -? flow->in_port >= MAX_PORTS
> -: flow->in_port != OFPP_LOCAL && flow->in_port != OFPP_NONE) {
> +
Thanks for the explanation,
On Thu, Jun 20, 2013 at 12:47 PM, Ben Pfaff wrote:
> On Thu, Jun 20, 2013 at 12:35:57PM -0700, Alex Wang wrote:
> > And sorry, I should have put you as co-author in the last commit.
>
> I don't think it was warranted, you did most of the work.
>
> > On Thu, Jun 20, 2
On Thu, Jun 20, 2013 at 12:35:57PM -0700, Alex Wang wrote:
> And sorry, I should have put you as co-author in the last commit.
I don't think it was warranted, you did most of the work.
> On Thu, Jun 20, 2013 at 10:53 AM, Ben Pfaff wrote:
>
> > On Wed, Jun 19, 2013 at 04:58:44PM -0700, Alex Wang
Thanks very much, Ben,
And sorry, I should have put you as co-author in the last commit.
On Thu, Jun 20, 2013 at 10:53 AM, Ben Pfaff wrote:
> On Wed, Jun 19, 2013 at 04:58:44PM -0700, Alex Wang wrote:
> > Currently datapath ports and openflow ports are both represented by
> unsigned
> > intege
On Wed, Jun 19, 2013 at 04:58:44PM -0700, Alex Wang wrote:
> Currently datapath ports and openflow ports are both represented by unsigned
> integers of various sizes. With implicit casts, etc. it is easy to mix them
> up and use one where the other is expected. This commit creates two typedefs
> of
