Re: [ovs-dev] [PATCH V2 2/2] bfd: Implements forwarding_if_rx

2013-08-21 Thread Alex Wang
Hey Ethan, > Basically if the remote endpoint signaled cpath down, and > forwarding_if_rx is enabled, that state should be sticky even if we > lose some of their packets. > We do have a similar issue in BFD. I'm not sure if I fully understand your suggestion. But I have a intuitive fix below:

Re: [ovs-dev] [PATCH V2 2/2] bfd: Implements forwarding_if_rx

2013-08-21 Thread Alex Wang
On Wed, Aug 21, 2013 at 2:26 PM, Ethan Jackson wrote: > This patch is basically ready, two minor comments and we'll get it merged > today. > > First the title line should be changed to "bfd: Implement > forwarding_if_rx." Note the period. > > Yes, how could I miss that. > > > > -return bf

Re: [ovs-dev] [PATCH V2 2/2] bfd: Implements forwarding_if_rx

2013-08-21 Thread Ethan Jackson
This patch is basically ready, two minor comments and we'll get it merged today. First the title line should be changed to "bfd: Implement forwarding_if_rx." Note the period. > > -return bfd->state == STATE_UP > -&& bfd->rmt_diag != DIAG_PATH_DOWN > -&& bfd->rmt_diag != DIAG_

[ovs-dev] [PATCH V2 2/2] bfd: Implements forwarding_if_rx

2013-08-20 Thread Alex Wang
This commit adds a new boolean option "forwarding_if_rx" to bfd. When forwarding_if_rx is true the interface will be considered capabale of packet I/O as long as there is packet received at interface. This is important in that when link becomes temporarily conjested, consecutive BFD control packe