Re: [ovs-dev] [PATCH V2 01/10] netdev: Extend rx_recv to pass multiple packets.

2014-03-21 Thread Jarno Rajahalme
On Mar 21, 2014, at 2:28 PM, Pravin Shelar wrote: > On Fri, Mar 21, 2014 at 1:55 PM, Thomas Graf wrote: >> On 03/21/2014 07:02 PM, Pravin wrote: >>> >>> diff --git a/lib/automake.mk b/lib/automake.mk >>> >>> @@ -1863,7 +1850,7 @@ dp_netdev_port_input(struct dp_netdev *dp, struct >>> ofpbuf *p

Re: [ovs-dev] [PATCH V2 01/10] netdev: Extend rx_recv to pass multiple packets.

2014-03-21 Thread Pravin Shelar
On Fri, Mar 21, 2014 at 2:48 PM, Thomas Graf wrote: > On 03/21/2014 10:28 PM, Pravin Shelar wrote: > >> I think it is not possible. Why vswitchd would generate such action if >> the packet is not going somewhere? > > > [...] > > >> right, there is memory leak for packet size less than eth-header.

Re: [ovs-dev] [PATCH V2 01/10] netdev: Extend rx_recv to pass multiple packets.

2014-03-21 Thread Thomas Graf
On 03/21/2014 10:28 PM, Pravin Shelar wrote: I think it is not possible. Why vswitchd would generate such action if the packet is not going somewhere? [...] right, there is memory leak for packet size less than eth-header. unfortunately dp_netdev_port_input() would not know if packet is dele

Re: [ovs-dev] [PATCH V2 01/10] netdev: Extend rx_recv to pass multiple packets.

2014-03-21 Thread Pravin Shelar
On Fri, Mar 21, 2014 at 1:55 PM, Thomas Graf wrote: > On 03/21/2014 07:02 PM, Pravin wrote: >> >> diff --git a/lib/automake.mk b/lib/automake.mk >> >> @@ -1863,7 +1850,7 @@ dp_netdev_port_input(struct dp_netdev *dp, struct >> ofpbuf *packet, >> dp_netdev_flow_used(netdev_flow, packet, &k

Re: [ovs-dev] [PATCH V2 01/10] netdev: Extend rx_recv to pass multiple packets.

2014-03-21 Thread Thomas Graf
On 03/21/2014 07:02 PM, Pravin wrote: diff --git a/lib/automake.mk b/lib/automake.mk @@ -1863,7 +1850,7 @@ dp_netdev_port_input(struct dp_netdev *dp, struct ofpbuf *packet, dp_netdev_flow_used(netdev_flow, packet, &key); actions = dp_netdev_flow_get_actions(netdev_flow); -

[ovs-dev] [PATCH V2 01/10] netdev: Extend rx_recv to pass multiple packets.

2014-03-21 Thread Pravin
DPDK can receive multiple packets but current netdev API does not allow that. Following patch allows dpif-netdev receive batch of packet in a rx_recv() call for any netdev port. This will be used by dpdk-netdev. Signed-off-by: Pravin B Shelar --- v1-v2: - handle drop action case. - avoid alloca