Re: [ovs-dev] [PATCH V2] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-16 Thread Alex Wang
Thx for the reviews, Ben and Joe, Applied the patch to master, branch-2.[0,1,3] Alex Wang, On Wed, Jul 16, 2014 at 2:43 AM, Joe Stringer wrote: > I took another read through, minor nitpicks if you haven't pushed the > patch yet:- > > > On 16 July 2014 17:21, Alex Wang wrote: > >> + * FWD:

Re: [ovs-dev] [PATCH V2] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-16 Thread Joe Stringer
I took another read through, minor nitpicks if you haven't pushed the patch yet:- On 16 July 2014 17:21, Alex Wang wrote: > > + * FWD: the port should forward any incomging non-stp-bpdu > + * packets. > incomging -> incoming bpdu -> BPDU + * TX_BPDU/RX_BPDU: th

Re: [ovs-dev] [PATCH V2] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Joe Stringer
Acked-by: Joe Stringer On 16 July 2014 17:21, Alex Wang wrote: > Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) > makes ovs drop the stp bpdu packets if stp is not enabled on the > input port. However, when pif bridge is used and stp is enabled > on the integration bridge.

[ovs-dev] [PATCH V2] stp: Make stp-disabled port forward stp bpdu packets.

2014-07-15 Thread Alex Wang
Commit 0d1cee123a84 (stp: Fix bpdu tx problem in listening state) makes ovs drop the stp bpdu packets if stp is not enabled on the input port. However, when pif bridge is used and stp is enabled on the integration bridge. The flow translation of stp bpdu packets will go through a level of resubmi