On 28.10.2016 13:44, Loftus, Ciara wrote:
>>
>>> I'll post few comments to v4 here.
>>>
static int
+dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode)
+{
+char *devargs;
+int err = 0;
+uint8_t port_no = 0;
+uint32_t driver_id = -1;
+
>>
>
> > I'll post few comments to v4 here.
> >
> > > static int
> > > +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode)
> > > +{
> > > +char *devargs;
> > > +int err = 0;
> > > +uint8_t port_no = 0;
> > > +uint32_t driver_id = -1;
> > > +
> > > +if (id_pool_alloc_id(dpdk
> I'll post few comments to v4 here.
>
> > static int
> > +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode)
> > +{
> > +char *devargs;
> > +int err = 0;
> > +uint8_t port_no = 0;
> > +uint32_t driver_id = -1;
> > +
> > +if (id_pool_alloc_id(dpdk_get_vhost_id_pool(), &d
I'll post few comments to v4 here.
> static int
> +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode)
> +{
> +char *devargs;
> +int err = 0;
> +uint8_t port_no = 0;
> +uint32_t driver_id = -1;
> +
> +if (id_pool_alloc_id(dpdk_get_vhost_id_pool(), &driver_id)) {
> +
>
> On 20.10.2016 19:33, Loftus, Ciara wrote:
> @@ -894,6 +1006,66 @@ dpdk_dev_parse_name(const char
> >> dev_name[], const char prefix[],
> }
> }
>
> +/* When attaching a vhost device to DPDK, a unique name of the
> format
> + * 'net_vhostX' is expected, where
On 20.10.2016 19:33, Loftus, Ciara wrote:
@@ -894,6 +1006,66 @@ dpdk_dev_parse_name(const char
>> dev_name[], const char prefix[],
}
}
+/* When attaching a vhost device to DPDK, a unique name of the format
+ * 'net_vhostX' is expected, where X is a unique identif
>
> Sorry, CC mail-list
>
> On 20.10.2016 17:20, Ilya Maximets wrote:
> > Not a complete review.
> > Few comments inline.
Thanks for the review. Comments inline.
Thanks,
Ciara
> >
> > Best regards, Ilya Maximets.
> >
> > On 14.10.2016 17:08, Ciara Loftus wrote:
> >> The vHost PMD allows vHost
Sorry, CC mail-list
On 20.10.2016 17:20, Ilya Maximets wrote:
> Not a complete review.
> Few comments inline.
>
> Best regards, Ilya Maximets.
>
> On 14.10.2016 17:08, Ciara Loftus wrote:
>> The vHost PMD allows vHost User ports to be controlled by the
>> librte_ether API, like physical 'dpdk' p
The vHost PMD allows vHost User ports to be controlled by the
librte_ether API, like physical 'dpdk' ports and IVSHM 'dpdkr' ports.
This commit integrates this PMD into OVS and removes direct calls to the
librte_vhost DPDK library.
This commit requires DPDK v16.11 functionality that isn't availabl
