Re: [ovs-dev] [PATCH RFC] ovsdb-server: Preserve remotes across crash and restart.

2013-06-13 Thread Gurucharan Shetty
On Thu, Jun 13, 2013 at 9:14 AM, Ben Pfaff wrote: > On Thu, Jun 13, 2013 at 08:29:25AM -0700, Gurucharan Shetty wrote: > > On Wed, Jun 12, 2013 at 5:10 PM, Ben Pfaff wrote: > > > This is unpolished but it shows the approach I have in mind. > > > Sending out for comments on the approach. > > > >

Re: [ovs-dev] [PATCH RFC] ovsdb-server: Preserve remotes across crash and restart.

2013-06-13 Thread Ben Pfaff
On Thu, Jun 13, 2013 at 08:50:42AM -0700, Gurucharan Shetty wrote: > On Thu, Jun 13, 2013 at 8:29 AM, Gurucharan Shetty wrote: > > > On Wed, Jun 12, 2013 at 5:10 PM, Ben Pfaff wrote: > > > >> --- > >> This is unpolished but it shows the approach I have in mind. > >> Sending out for comments on th

Re: [ovs-dev] [PATCH RFC] ovsdb-server: Preserve remotes across crash and restart.

2013-06-13 Thread Ben Pfaff
On Thu, Jun 13, 2013 at 08:29:25AM -0700, Gurucharan Shetty wrote: > On Wed, Jun 12, 2013 at 5:10 PM, Ben Pfaff wrote: > > This is unpolished but it shows the approach I have in mind. > > Sending out for comments on the approach. > > > I am fine with the approach. The two negatives I see with this

Re: [ovs-dev] [PATCH RFC] ovsdb-server: Preserve remotes across crash and restart.

2013-06-13 Thread Gurucharan Shetty
On Thu, Jun 13, 2013 at 8:29 AM, Gurucharan Shetty wrote: > On Wed, Jun 12, 2013 at 5:10 PM, Ben Pfaff wrote: > >> --- >> This is unpolished but it shows the approach I have in mind. >> Sending out for comments on the approach. >> > I am fine with the approach. The two negatives I see with this:

Re: [ovs-dev] [PATCH RFC] ovsdb-server: Preserve remotes across crash and restart.

2013-06-13 Thread Gurucharan Shetty
On Wed, Jun 12, 2013 at 5:10 PM, Ben Pfaff wrote: > --- > This is unpolished but it shows the approach I have in mind. > Sending out for comments on the approach. > I am fine with the approach. The two negatives I see with this: * If /tmp is cleaned up routinely, we will loose the information. If

[ovs-dev] [PATCH RFC] ovsdb-server: Preserve remotes across crash and restart.

2013-06-12 Thread Ben Pfaff
--- This is unpolished but it shows the approach I have in mind. Sending out for comments on the approach. diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 20e1964..d87360a 100644 --- a/ovsdb/ovsdb-server.c +++ b/ovsdb/ovsdb-server.c @@ -81,8 +81,14 @@ struct add_remote_aux { st