Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Jesse Gross
It doesn't trigger on my system (since it is due to uninitialized memory) but I saw the problem from the autobuilder. I just pushed a patch to fix it: https://github.com/openvswitch/ovs/commit/46e7137c77d845c488e17b718eac7c3fb97cedcc Hopefully that's everything... On Tue, Apr 7, 2015 at 6:57 PM,

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Gurucharan Shetty
It looks like this series also breaks the unit tests on Linux. Do you see it? tnl_push(tnl_port(6),header(size=50,type=5,eth(dst=f8:bc:12:44:34:b6,src=f8:bc:12:46:58:e0,dl_type=0x0800),ipv4(src=1.1.2.88,dst=1.1.2.92,proto=17,tos=0,ttl=64,frag=0x40),udp(src=0,dst=6081,csum=0x0),geneve(oam,vni=0x1c7)

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Gurucharan Shetty
On Tue, Apr 7, 2015 at 6:01 PM, Jesse Gross wrote: > Thanks, I pushed a fix to avoid this - nothing was using the member at > the moment, so I just replaced it with a comment. Thank you for the quick fix! > > On Tue, Apr 7, 2015 at 5:31 PM, Gurucharan Shetty wrote: >> The following series break

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Jesse Gross
Thanks, I pushed a fix to avoid this - nothing was using the member at the moment, so I just replaced it with a comment. On Tue, Apr 7, 2015 at 5:31 PM, Gurucharan Shetty wrote: > The following series breaks windows build. Zero length arrays are not > supported in the middle of structures. > > so

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Gurucharan Shetty
The following series breaks windows build. Zero length arrays are not supported in the middle of structures. source='lib/bfd.c' object='lib/bfd.lo' libtool=yes \ DEPDIR=.deps depmode=none /bin/sh ./build-aux/depcomp \ /bin/sh ./libtool --tag=CC --mode=compile build-aux/cccl -DHAVE_CONFIG_H -I. -I

Re: [ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-04-07 Thread Pravin Shelar
On Mon, Mar 30, 2015 at 3:14 PM, Jesse Gross wrote: > Kernel based OVS recently added the ability to support checksums > for UDP based tunnels (Geneve and VXLAN). This adds similar support > for the userspace datapath to bring feature parity. > > Signed-off-by: Jesse Gross Thanks for adding Gen

[ovs-dev] [PATCH 9/9] tunneling: Add UDP checksum support for userspace tunnels.

2015-03-30 Thread Jesse Gross
Kernel based OVS recently added the ability to support checksums for UDP based tunnels (Geneve and VXLAN). This adds similar support for the userspace datapath to bring feature parity. Signed-off-by: Jesse Gross --- lib/netdev-vport.c | 37 ++--- lib/odp-uti