Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-09-01 Thread Andy Zhou
Sorry for pushing the wrong button :) On Tue, Sep 1, 2015 at 4:26 PM, Ben Pfaff wrote: > On Tue, Sep 1, 2015 at 4:23 PM, Jarno Rajahalme wrote: >>> On Sep 1, 2015, at 3:34 PM, Andy Zhou wrote: >>> I'm really uncertain about patches 7 and 8 because they didn't make a significant d

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-09-01 Thread Ben Pfaff
On Tue, Sep 1, 2015 at 4:23 PM, Jarno Rajahalme wrote: >> On Sep 1, 2015, at 3:34 PM, Andy Zhou wrote: >> >>> >>> I'm really uncertain about patches 7 and 8 because they didn't make a >>> significant difference. I'm happy with the rest of the patches. >> >> Thanks for the review. I dropped 7 and

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-09-01 Thread Jarno Rajahalme
> On Sep 1, 2015, at 3:34 PM, Andy Zhou wrote: > >> >> I'm really uncertain about patches 7 and 8 because they didn't make a >> significant difference. I'm happy with the rest of the patches. > > Thanks for the review. I dropped 7 and 8, and > pushed the reset. I hope nothing bad happens :

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-09-01 Thread Andy Zhou
> > I'm really uncertain about patches 7 and 8 because they didn't make a > significant difference. I'm happy with the rest of the patches. Thanks for the review. I dropped 7 and 8, and pushed the reset. ___ dev mailing list dev@openvswitch.org http://o

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-09-01 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 02:56:48PM -0700, Andy Zhou wrote: > On Fri, Aug 21, 2015 at 10:48 AM, Ben Pfaff wrote: > > On Tue, Aug 11, 2015 at 05:55:14PM -0700, Andy Zhou wrote: > >> Json string are usually created and freed immediately. Thus, there > >> should not be any downside in creating a large

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-08-21 Thread Andy Zhou
On Fri, Aug 21, 2015 at 10:48 AM, Ben Pfaff wrote: > On Tue, Aug 11, 2015 at 05:55:14PM -0700, Andy Zhou wrote: >> Json string are usually created and freed immediately. Thus, there >> should not be any downside in creating a larger buffer initially to >> avoid the cost of moving strings around in

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-08-21 Thread Ben Pfaff
On Tue, Aug 11, 2015 at 05:55:14PM -0700, Andy Zhou wrote: > Json string are usually created and freed immediately. Thus, there > should not be any downside in creating a larger buffer initially to > avoid the cost of moving strings around in memory due to realloc() > call. > > The following scrip

[ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-08-11 Thread Andy Zhou
Json string are usually created and freed immediately. Thus, there should not be any downside in creating a larger buffer initially to avoid the cost of moving strings around in memory due to realloc() call. The following script is used as benchmark to measure number of bytes reallocated: ovs-vsc