Re: [ovs-dev] [PATCH 7/8] lib/classifier: Clarify find_match_wc().

2014-06-26 Thread Jarno Rajahalme
On Jun 13, 2014, at 10:34 AM, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 11:53:54AM -0700, Jarno Rajahalme wrote: >> Reduce the number of goto statements by returning via a new helper >> fill_range_wc() when no match is found. >> >> Signed-off-by: Jarno Rajahalme > > I slightly lean toward ma

Re: [ovs-dev] [PATCH 7/8] lib/classifier: Clarify find_match_wc().

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:54AM -0700, Jarno Rajahalme wrote: > Reduce the number of goto statements by returning via a new helper > fill_range_wc() when no match is found. > > Signed-off-by: Jarno Rajahalme I slightly lean toward making fill_range_wc() a void function, but this is OK too. A

[ovs-dev] [PATCH 7/8] lib/classifier: Clarify find_match_wc().

2014-06-09 Thread Jarno Rajahalme
Reduce the number of goto statements by returning via a new helper fill_range_wc() when no match is found. Signed-off-by: Jarno Rajahalme --- lib/classifier.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/lib/classifier.c b/lib/clas