Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-19 Thread Pravin Shelar
On Thu, Jun 19, 2014 at 4:47 PM, Jesse Gross wrote: > On Thu, Jun 19, 2014 at 4:30 PM, Pravin Shelar wrote: >> On Thu, Jun 19, 2014 at 4:07 PM, Jesse Gross wrote: >>> On Thu, Jun 19, 2014 at 1:33 PM, Pravin Shelar wrote: > diff --git a/datapath/flow.c b/datapath/flow.c > index f1bb95d..

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-19 Thread Jesse Gross
On Thu, Jun 19, 2014 at 4:30 PM, Pravin Shelar wrote: > On Thu, Jun 19, 2014 at 4:07 PM, Jesse Gross wrote: >> On Thu, Jun 19, 2014 at 1:33 PM, Pravin Shelar wrote: diff --git a/datapath/flow.c b/datapath/flow.c index f1bb95d..7b108ed 100644 --- a/datapath/flow.c +++ b/datapa

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-19 Thread Pravin Shelar
On Thu, Jun 19, 2014 at 4:07 PM, Jesse Gross wrote: > On Thu, Jun 19, 2014 at 1:33 PM, Pravin Shelar wrote: >> git am warning: >> /home/pravin/ovs/w7/.git/rebase-apply/patch:53: trailing whitespace. >> >> } >> >> warning: 1 line adds whitespace errors. > > Fixed. > >>

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-19 Thread Jesse Gross
On Thu, Jun 19, 2014 at 1:33 PM, Pravin Shelar wrote: > git am warning: > /home/pravin/ovs/w7/.git/rebase-apply/patch:53: trailing whitespace. > > } > > warning: 1 line adds whitespace errors. Fixed. > --- > compiler warning: > > lib/odp-ut

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-19 Thread Pravin Shelar
git am warning: /home/pravin/ovs/w7/.git/rebase-apply/patch:53: trailing whitespace. } warning: 1 line adds whitespace errors. --- compiler warning: lib/odp-util.c:869:15: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'struct g

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-11 Thread Jesse Gross
On Wed, Jun 11, 2014 at 1:58 PM, Thomas Graf wrote: > On 06/11/14 at 11:23am, Jesse Gross wrote: >> These two pieces are actually related. >> >> All of the operations during flow lookup (flow extraction, masking, >> hashing, and comparison) are now variable length to the relevant data. >> For non-

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-11 Thread Thomas Graf
On 06/11/14 at 11:23am, Jesse Gross wrote: > These two pieces are actually related. > > All of the operations during flow lookup (flow extraction, masking, > hashing, and comparison) are now variable length to the relevant data. > For non-Geneve packets, the option field won't be part of the > sig

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-11 Thread Jesse Gross
On Wed, Jun 11, 2014 at 4:58 AM, Thomas Graf wrote: > On 06/10/14 at 04:47pm, Jesse Gross wrote: >> diff --git a/datapath/flow.h b/datapath/flow.h >> index 0ecf78b..5d8383c 100644 >> --- a/datapath/flow.h >> +++ b/datapath/flow.h >> @@ -53,11 +53,20 @@ struct ovs_key_ipv4_tunnel { >> >> struct ov

Re: [ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-11 Thread Thomas Graf
On 06/10/14 at 04:47pm, Jesse Gross wrote: > diff --git a/datapath/flow.c b/datapath/flow.c > index f1bb95d..7b108ed 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > @@ -455,6 +455,13 @@ int ovs_flow_extract(struct sk_buff *skb, u16 in_port, > struct sw_flow_key *key) > struc

[ovs-dev] [PATCH 7/7] datapath: Add support for Geneve tunneling.

2014-06-10 Thread Jesse Gross
This adds support for Geneve - Generic Network Virtualization Encapsulation. The protocol is documented at http://tools.ietf.org/html/draft-gross-geneve-00 The kernel implementation is completely agnostic to the options that are in use and can handle newly defined options without further work. It