Re: [ovs-dev] [PATCH 6/9] odp-util: Correctly [de]serialize mask for ND attributes.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 15:16, "Jarno Rajahalme" wrote: >With the comment below, > >Acked-by: Jarno Rajahalme > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> When converting between ODP attributes and struct flow_wildcards, we >> check that all the prerequisites are exact matched o

Re: [ovs-dev] [PATCH 6/9] odp-util: Correctly [de]serialize mask for ND attributes.

2015-12-10 Thread Jarno Rajahalme
With the comment below, Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > When converting between ODP attributes and struct flow_wildcards, we > check that all the prerequisites are exact matched on the mask. > > For ND(ICMPv6) attributes, an exact matc

[ovs-dev] [PATCH 6/9] odp-util: Correctly [de]serialize mask for ND attributes.

2015-12-09 Thread Daniele Di Proietto
When converting between ODP attributes and struct flow_wildcards, we check that all the prerequisites are exact matched on the mask. For ND(ICMPv6) attributes, an exact match on tp_src and tp_dst (which in this context are the icmp type and code) shold look like htons(0xff), not htons(0x). Fi