Re: [ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 03:12:02PM -0700, Jarno Rajahalme wrote: > > On Oct 17, 2013, at 12:40 PM, Ben Pfaff wrote: > > > On Wed, Oct 16, 2013 at 04:16:08PM -0700, Jarno Rajahalme wrote: > >> Signed-off-by: Jarno Rajahalme > > > > Why is saving space here worthwhile? > > The difference in set

Re: [ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:40 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:08PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > Why is saving space here worthwhile? The difference in setting an IPv4 address, any register, port number, etc., is 8 bytes vs. 24 bytes (i.

Re: [ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:08PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Why is saving space here worthwhile? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 6/9] More compact ofpact_set_field.

2013-10-16 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/meta-flow.h |2 +- lib/ofp-actions.c| 44 +++--- lib/ofp-actions.h| 48 +- lib/ofp-parse.c | 14 ++-- lib/ofp-util.c