Re: [ovs-dev] [PATCH 6/8] nx-match: Update register check functions.

2011-08-12 Thread Ethan Jackson
Eh, silly mistake. Thanks. Ethan On Fri, Aug 12, 2011 at 12:06, Ben Pfaff wrote: > In bundle_check(), this: >> +            error = nxm_dst_check(nab->dst, ofs, n_bits, flow) || error; > will assign 'error' either 0 or 1, not 0 or an OpenFlow error code. > > Otherwise this looks good to me. > _

Re: [ovs-dev] [PATCH 6/8] nx-match: Update register check functions.

2011-08-12 Thread Ben Pfaff
In bundle_check(), this: > +error = nxm_dst_check(nab->dst, ofs, n_bits, flow) || error; will assign 'error' either 0 or 1, not 0 or an OpenFlow error code. Otherwise this looks good to me. ___ dev mailing list dev@openvswitch.org http://open

[ovs-dev] [PATCH 6/8] nx-match: Update register check functions.

2011-08-12 Thread Ethan Jackson
This patch simplifies the API of nxm_dst_check() and adds a new function nxm_src_check() for checking source fields. --- lib/autopath.c | 11 - lib/bundle.c| 11 - lib/multipath.c |7 +- lib/nx-match.c | 62 --