Re: [ovs-dev] [PATCH 6/7] packets: Fix null pointer dereference reported by clang.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:27PM -0700, William Tu wrote: > In packet_set_tcp_port(), clang reports passing null pointer of &th->tcp_src > when calling packet_set_port(&th->tcp_src, src, &th->tcp_csum); > > Signed-off-by: William Tu I don't see how this can happen. If it can, it seems like th

[ovs-dev] [PATCH 6/7] packets: Fix null pointer dereference reported by clang.

2016-06-28 Thread William Tu
In packet_set_tcp_port(), clang reports passing null pointer of &th->tcp_src when calling packet_set_port(&th->tcp_src, src, &th->tcp_csum); Signed-off-by: William Tu --- lib/packets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/packets.c b/lib/packets.c index 43b5a70