Re: [ovs-dev] [PATCH 6/7] lib/flow: Reduce calls to count_1bits().

2014-10-07 Thread Ben Pfaff
Thanks. I applied this change. On Mon, Oct 06, 2014 at 04:01:57PM -0700, Jarno Rajahalme wrote: > Ben, > > This is much cleaner, thanks! > > Acked-by: Jarno Rajahalme > > > On Oct 6, 2014, at 2:17 PM, Ben Pfaff wrote: > > > On Wed, Oct 01, 2014 at 04:02:36PM -0700, Jarno Rajahalme wrote: >

Re: [ovs-dev] [PATCH 6/7] lib/flow: Reduce calls to count_1bits().

2014-10-06 Thread Jarno Rajahalme
Ben, This is much cleaner, thanks! Acked-by: Jarno Rajahalme On Oct 6, 2014, at 2:17 PM, Ben Pfaff wrote: > On Wed, Oct 01, 2014 at 04:02:36PM -0700, Jarno Rajahalme wrote: >> Depending on the CPU, count_1bits() may be more or less expensive, so >> it is better to avoid unnecessary calls to

Re: [ovs-dev] [PATCH 6/7] lib/flow: Reduce calls to count_1bits().

2014-10-06 Thread Ben Pfaff
On Wed, Oct 01, 2014 at 04:02:36PM -0700, Jarno Rajahalme wrote: > Depending on the CPU, count_1bits() may be more or less expensive, so > it is better to avoid unnecessary calls to it. When the map has > consecutive 1-bits, those can be cleared without counting. > > Signed-off-by: Jarno Rajahalm

[ovs-dev] [PATCH 6/7] lib/flow: Reduce calls to count_1bits().

2014-10-01 Thread Jarno Rajahalme
Depending on the CPU, count_1bits() may be more or less expensive, so it is better to avoid unnecessary calls to it. When the map has consecutive 1-bits, those can be cleared without counting. Signed-off-by: Jarno Rajahalme --- lib/flow.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(