Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-13 Thread Thomas Graf
On 01/13/15 at 02:15pm, Jesse Gross wrote: > On Mon, Jan 12, 2015 at 5:02 PM, Thomas Graf wrote: > > What about if we only apply tun_info->options on Geneve if > > TUNNEL_GENEVE_OPT is set and vice versa? > > That seems nice and simple to me. Great! I have implemented this in v4 of the series as

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-13 Thread Jesse Gross
On Mon, Jan 12, 2015 at 5:02 PM, Thomas Graf wrote: > On 01/12/15 at 01:54pm, Jesse Gross wrote: >> On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote: >> > + if (!is_mask) >> > + SW_FLOW_KEY_PUT(match, tun_opts_len, sizeof(opts), false); >> > + else >> > +

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-12 Thread Thomas Graf
On 01/12/15 at 01:54pm, Jesse Gross wrote: > On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote: > > + if (tb[OVS_VXLAN_EXT_MAX]) > > + opts.gbp = nla_get_u32(tb[OVS_VXLAN_EXT_MAX]); > > Shouldn't this be OVS_VXLAN_EXT_GBP instead of OVS_VXLAN_EXT_MAX? > (They have the same va

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-12 Thread Jesse Gross
On Mon, Jan 12, 2015 at 4:26 AM, Thomas Graf wrote: > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > index 457ccf3..cea492b 100644 > --- a/net/openvswitch/flow_netlink.c > +++ b/net/openvswitch/flow_netlink.c > +static int vxlan_tun_opt_from_nlattr(const struct nlat

[ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-12 Thread Thomas Graf
Introduces support for the group policy extension to the VXLAN virtual port. The extension is disabled by default and only enabled if the user has provided the respective configuration. ovs-vsctl add-port br0 vxlan0 -- \ set Interface vxlan0 type=vxlan options:exts=gbp The configuration in

[ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-08 Thread Thomas Graf
Introduces support for the group policy extension to the VXLAN virtual port. The extension is disabled by default and only enabled if the user has provided the respective configuration. ovs-vsctl add-port br0 vxlan0 -- \ set Interface vxlan0 type=vxlan options:exts=gbp The configuration in

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-08 Thread Thomas Graf
On 01/07/15 at 05:18pm, Jesse Gross wrote: > On Wed, Jan 7, 2015 at 3:01 PM, Thomas Graf wrote: > > The encoding will be based on struct ovs_vxlan_opts which is extended > > as needed by appending new members to the end of the struct. Parsers > > will look at the provided length to see which field

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-07 Thread Jesse Gross
On Wed, Jan 7, 2015 at 3:01 PM, Thomas Graf wrote: > On 01/07/15 at 02:46pm, Jesse Gross wrote: >> On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote: >> > The group policy metadata is handled in the same way as Geneve options >> > and transported as binary blob in a new Netlink attribute >> > OVS

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-07 Thread Thomas Graf
On 01/07/15 at 02:46pm, Jesse Gross wrote: > On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote: > > The group policy metadata is handled in the same way as Geneve options > > and transported as binary blob in a new Netlink attribute > > OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS which is mutually exclusive to

Re: [ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-07 Thread Jesse Gross
On Tue, Jan 6, 2015 at 6:05 PM, Thomas Graf wrote: > The group policy metadata is handled in the same way as Geneve options > and transported as binary blob in a new Netlink attribute > OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS which is mutually exclusive to the > existing OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS. C

[ovs-dev] [PATCH 6/6] openvswitch: Support VXLAN Group Policy extension

2015-01-06 Thread Thomas Graf
Introduces support for the group policy extension to the VXLAN virtual port. The extension is disabled by default and only enabled if the user has provided the respective configuration. ovs-vsctl add-port br0 vxlan0 -- \ set Interface vxlan0 type=vxlan options:exts=gbp The configuration in