Re: [ovs-dev] [PATCH 6/6] nicra-ext: New action NXAST_OUTPUT_REG.

2011-08-12 Thread Ben Pfaff
On Fri, Aug 12, 2011 at 11:48:42AM -0700, Ethan Jackson wrote: > Thanks for the review. I've supplied an incremental below. The series has > changed enough that I'm going to resend the entire thing for completeness. Thanks, I would appreciate that. > > Let's add a requirement that pad[] in stru

[ovs-dev] Re: [ovs-dev] [PATCH 6/6] nicra-ext: New action NXAST_OUTPUT_REG.

2011-08-12 Thread Ethan Jackson
Thanks for the review. I've supplied an incremental below. The series has changed enough that I'm going to resend the entire thing for completeness. > Let's add a requirement that pad[] in struct nx_action_output_reg be > all-bytes-zero, in case we want to extend it later. I was wondering about

Re: [ovs-dev] [PATCH 6/6] nicra-ext: New action NXAST_OUTPUT_REG.

2011-08-11 Thread Ben Pfaff
On Wed, Aug 10, 2011 at 05:21:43PM -0700, Ethan Jackson wrote: > The NXAST_OUTPUT_REG outputs to the OpenFlow port contained in a > supplied NXM field. I think that the NEWS item should say that we've added an OpenFlow extension to output to the port given in a field, instead of just saying that "

Re: [ovs-dev] [PATCH 6/6] nicra-ext: New action NXAST_OUTPUT_REG.

2011-08-10 Thread Ethan Jackson
> The NXAST_OUTPUT_REG outputs to the OpenFlow port contained in a > supplied NXM field. This should read: The NXAST_OUTPUT_REG action outputs to the OpenFlow port contained in a supplied NXM field. ___ dev mailing list dev@openvswitch.org http://

[ovs-dev] [PATCH 6/6] nicra-ext: New action NXAST_OUTPUT_REG.

2011-08-10 Thread Ethan Jackson
The NXAST_OUTPUT_REG outputs to the OpenFlow port contained in a supplied NXM field. --- NEWS |2 ++ include/openflow/nicira-ext.h | 31 ++- lib/ofp-parse.c | 23 ++- lib/ofp-print.c |8