Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 03:32:03PM -0700, Jarno Rajahalme wrote: > > On Oct 17, 2013, at 12:37 PM, Ben Pfaff wrote: > > > On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: > >> This is a little bit simpler and marginally more efficient, but also makes > >> following changes easier

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:44 PM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 12:37:27PM -0700, Ben Pfaff wrote: >> On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: >>> This is a little bit simpler and marginally more efficient, but also makes >>> following changes easier. >>> >>> Si

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 12:37 PM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: >> This is a little bit simpler and marginally more efficient, but also makes >> following changes easier. >> >> Signed-off-by: Jarno Rajahalme > > I had to read the patch before

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 12:37:27PM -0700, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: > > This is a little bit simpler and marginally more efficient, but also makes > > following changes easier. > > > > Signed-off-by: Jarno Rajahalme > > I had to read the

Re: [ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:07PM -0700, Jarno Rajahalme wrote: > This is a little bit simpler and marginally more efficient, but also makes > following changes easier. > > Signed-off-by: Jarno Rajahalme I had to read the patch before I understood what it did. Could you elaborate the change lo

[ovs-dev] [PATCH 5/9] Native OpenFlow 1.2 set_field action support.

2013-10-16 Thread Jarno Rajahalme
This is a little bit simpler and marginally more efficient, but also makes following changes easier. Signed-off-by: Jarno Rajahalme --- lib/meta-flow.c | 10 +--- lib/meta-flow.h | 10 +++- lib/nx-match.c | 131 ++--