Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-26 Thread Jarno Rajahalme
Pushed to master with changes as suggested. Defined inline functions shown below, be32 variants were obsolete by earlier changes, so did not add them now. +static inline uint32_t flow_u32_value(const struct flow *flow, size_t index) +{ +return ((uint32_t *)(flow))[index]; +} + +static inline

Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:52AM -0700, Jarno Rajahalme wrote: > When, during a classifier lookup, we narrow down to a single potential > rule, it is enough to match on ("unwildcard") one bit that differs > between the packet and the rule. > > This is a special case of the more general algorithm

Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-13 Thread Ben Pfaff
On Fri, Jun 13, 2014 at 10:21:36AM -0700, Ben Pfaff wrote: > On Mon, Jun 09, 2014 at 11:53:52AM -0700, Jarno Rajahalme wrote: > > When, during a classifier lookup, we narrow down to a single potential > > rule, it is enough to match on ("unwildcard") one bit that differs > > between the packet and

Re: [ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-13 Thread Ben Pfaff
On Mon, Jun 09, 2014 at 11:53:52AM -0700, Jarno Rajahalme wrote: > When, during a classifier lookup, we narrow down to a single potential > rule, it is enough to match on ("unwildcard") one bit that differs > between the packet and the rule. > > This is a special case of the more general algorithm

[ovs-dev] [PATCH 5/8] lib/classifier: Optimize megaflows for single rule case.

2014-06-09 Thread Jarno Rajahalme
When, during a classifier lookup, we narrow down to a single potential rule, it is enough to match on ("unwildcard") one bit that differs between the packet and the rule. This is a special case of the more general algorithm, where it is sufficient to match on enough bits that separates the packet