Re: [ovs-dev] [PATCH 5/7] ovn-nbctl: Fix double memory free reported by clang.

2016-07-02 Thread Ben Pfaff
On Thu, Jun 30, 2016 at 09:37:29PM -0700, Darrell Ball wrote: > On Thu, Jun 30, 2016 at 2:31 PM, William Tu wrote: > > > Hi Darrell, > > > > Thanks, I think we should print the error in VLOG_WARN and free it . > > > > Regards, > > William > > > > Thanks > I only commented on grabbing the error r

Re: [ovs-dev] [PATCH 5/7] ovn-nbctl: Fix double memory free reported by clang.

2016-06-30 Thread Darrell Ball
On Thu, Jun 30, 2016 at 2:31 PM, William Tu wrote: > Hi Darrell, > > Thanks, I think we should print the error in VLOG_WARN and free it . > > Regards, > William > Thanks I only commented on grabbing the error return value and allowing it to be freed instead of removing the free() call to satisfy

Re: [ovs-dev] [PATCH 5/7] ovn-nbctl: Fix double memory free reported by clang.

2016-06-30 Thread William Tu
Hi Darrell, Thanks, I think we should print the error in VLOG_WARN and free it . Regards, William On Wed, Jun 29, 2016 at 10:08 AM, Darrell Ball wrote: > > > On Tue, Jun 28, 2016 at 10:02 PM, William Tu wrote: >> >> Variable 'error' has been free in line 1795. >> >> Signed-off-by: William Tu

Re: [ovs-dev] [PATCH 5/7] ovn-nbctl: Fix double memory free reported by clang.

2016-06-29 Thread Darrell Ball
On Tue, Jun 28, 2016 at 10:02 PM, William Tu wrote: > Variable 'error' has been free in line 1795. > > Signed-off-by: William Tu > --- > ovn/utilities/ovn-nbctl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c > index 345647a..3228a

[ovs-dev] [PATCH 5/7] ovn-nbctl: Fix double memory free reported by clang.

2016-06-28 Thread William Tu
Variable 'error' has been free in line 1795. Signed-off-by: William Tu --- ovn/utilities/ovn-nbctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 345647a..3228a03 100644 --- a/ovn/utilities/ovn-nbctl.c +++ b/ovn/utilities/ovn-nbct