Re: [ovs-dev] [PATCH 4/9] odp-util: Commit ICMP set only for ICMP packets.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 14:57, "Jarno Rajahalme" wrote: >With a note below, > >Acked-by: Jarno Rajahalme > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> commit_set_icmp_action() should do its job only if the packet is ICMP, >> otherwise there will be two problems: >> >> * A set IC

Re: [ovs-dev] [PATCH 4/9] odp-util: Commit ICMP set only for ICMP packets.

2015-12-10 Thread Jarno Rajahalme
With a note below, Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > commit_set_icmp_action() should do its job only if the packet is ICMP, > otherwise there will be two problems: > > * A set ICMP action will be inserted in the ODP actions and the flow

[ovs-dev] [PATCH 4/9] odp-util: Commit ICMP set only for ICMP packets.

2015-12-09 Thread Daniele Di Proietto
commit_set_icmp_action() should do its job only if the packet is ICMP, otherwise there will be two problems: * A set ICMP action will be inserted in the ODP actions and the flow will be slow pathed. * The tp_src and tp_dst field will be unwildcarded. Normal TCP or UDP packets won't be impacted,