On 10/12/2015 14:57, "Jarno Rajahalme" wrote:
>With a note below,
>
>Acked-by: Jarno Rajahalme
>
>> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto
>> wrote:
>>
>> commit_set_icmp_action() should do its job only if the packet is ICMP,
>> otherwise there will be two problems:
>>
>> * A set IC
With a note below,
Acked-by: Jarno Rajahalme
> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto
> wrote:
>
> commit_set_icmp_action() should do its job only if the packet is ICMP,
> otherwise there will be two problems:
>
> * A set ICMP action will be inserted in the ODP actions and the flow
commit_set_icmp_action() should do its job only if the packet is ICMP,
otherwise there will be two problems:
* A set ICMP action will be inserted in the ODP actions and the flow
will be slow pathed.
* The tp_src and tp_dst field will be unwildcarded.
Normal TCP or UDP packets won't be impacted,