Re: [ovs-dev] [PATCH 4/5] v2: ofproto: Implement OpenFlow 1.3 meter table.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 10:07:36AM -0700, Ben Pfaff wrote: > On Thu, Jun 27, 2013 at 01:39:51AM +0300, Jarno Rajahalme wrote: > > > > Signed-off-by: Jarno Rajahalme > > I'm looking this over. I wanted to tweak some stuff, so I sent it all out as another series starting here: http://open

Re: [ovs-dev] [PATCH 4/5] v2: ofproto: Implement OpenFlow 1.3 meter table.

2013-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2013 at 01:39:51AM +0300, Jarno Rajahalme wrote: > > Signed-off-by: Jarno Rajahalme I'm looking this over. I noticed that there are lots of meter_ids passed by pointer that could be passed by value. I am folding this in: diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index

[ovs-dev] [PATCH 4/5] v2: ofproto: Implement OpenFlow 1.3 meter table.

2013-06-26 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- v2: Addresses comments by Ben. --- lib/ofp-actions.c | 20 +- lib/ofp-actions.h |2 + lib/rconn.c| 14 +- ofproto/ofproto-dpif.c |4 + ofproto/ofproto-provider.h | 49 - ofproto/ofproto.c | 490 +