On Jun 28, 2013, at 1:00 AM, "Rajahalme, Jarno (NSN - FI/Espoo)"
wrote:
>> +if (flow->dl_type == htons(ETH_TYPE_IP)) {
>> +memset(&wc->masks.nw_src, 0xff, sizeof wc->masks.nw_src);
>> +memset(&wc->masks.nw_dst, 0xff, sizeof wc->masks.nw_dst);
>> +} else {
On Jun 28, 2013, at 4:16 , ext Justin Pettit wrote:
...
> diff --git a/lib/flow.c b/lib/flow.c
> index a42fea1..1a5084b 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
> @@ -781,7 +781,8 @@ flow_hash_symmetric_l4(const struct flow *flow, uint32_t
> basis)
>
> /* Masks the fields in 'wc' that are us
That's a good idea as a sanity check--especially since the consequences are bad
(the flow is rejected by the kernel). I'll look at adding that.
--Justin
On Jun 27, 2013, at 6:37 PM, Ethan Jackson wrote:
> Out of curiosity, we don't we simply not emit the wildcards for those
> fields of the p
Out of curiosity, we don't we simply not emit the wildcards for those
fields of the packet which are irrelevant? I.E. if an ethernet packet
says to exact match the IP src, simply don't when we translate from a
flow to an odp key?
Acked-by: Ethan Jackson
On Thu, Jun 27, 2013 at 6:16 PM, Justin P
When determining the fields to un-wildcard, we need to be careful
about only un-wildcarding fields that are relevant. Also, we
didn't properly handle IPv6 addresses.
Signed-off-by: Justin Pettit
---
lib/bond.c |4 ++--
lib/bundle.c|2 +-
lib/flow.c | 20 ++---
