Re: [ovs-dev] [PATCH 4/4 v2] netlink-socket.c: implement get pid support on Windows

2014-08-19 Thread Nithin Raju
On Aug 18, 2014, at 5:08 PM, Alin Serdean wrote: > Hi Nithin, > > Just a few thoughts: > Since get PID is a special case would it not be better to treat it as a > DeviceIoControl;dwIoControlCode like OVS_IOCTL_TRANSACT (i.e. > OVS_IOCTL_GET_PID)? > > We can drop the extra headers and the wh

Re: [ovs-dev] [PATCH 4/4 v2] netlink-socket.c: implement get pid support on Windows

2014-08-18 Thread Alin Serdean
a number. Thanks, Alin. -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Friday, August 15, 2014 6:36 AM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH 4/4 v2] netlink-socket.c: implement get pid support on Windows To verify if the

Re: [ovs-dev] [PATCH 4/4 v2] netlink-socket.c: implement get pid support on Windows

2014-08-18 Thread Ben Pfaff
On Thu, Aug 14, 2014 at 08:35:39PM -0700, Nithin Raju wrote: > To verify if the netlink support in the kernel works, I updated > the netlink-socket.c code to get the PID for a given device > descriptor. > > In the existing code, userspace sets the PID, which will not be > unique across different p

[ovs-dev] [PATCH 4/4 v2] netlink-socket.c: implement get pid support on Windows

2014-08-14 Thread Nithin Raju
To verify if the netlink support in the kernel works, I updated the netlink-socket.c code to get the PID for a given device descriptor. In the existing code, userspace sets the PID, which will not be unique across different processes. So, it is better for the kernel to generate the PID and give it