Re: [ovs-dev] [PATCH 4/4] ovn: Fix extra token detection.

2015-07-17 Thread Joe Stringer
On 16 July 2015 at 13:52, Ben Pfaff wrote: > On Wed, Jul 15, 2015 at 10:18:29PM -0700, Joe Stringer wrote: >> This code attempts to first check whether another error was detected for >> the string it is parsing, then if it's not at the end of the tokens, >> report an error. However, 'errorp' is al

Re: [ovs-dev] [PATCH 4/4] ovn: Fix extra token detection.

2015-07-16 Thread Ben Pfaff
On Wed, Jul 15, 2015 at 10:18:29PM -0700, Joe Stringer wrote: > This code attempts to first check whether another error was detected for > the string it is parsing, then if it's not at the end of the tokens, > report an error. However, 'errorp' is always a valid pointer to a > 'char *', so the firs

[ovs-dev] [PATCH 4/4] ovn: Fix extra token detection.

2015-07-15 Thread Joe Stringer
This code attempts to first check whether another error was detected for the string it is parsing, then if it's not at the end of the tokens, report an error. However, 'errorp' is always a valid pointer to a 'char *', so the first check in this statement always evaluates false. Furthermore, this b