On Jan 17, 2013, at 2:45 PM, Ben Pfaff wrote:
Thanks for your comments!
I have updated patches 1/4, 2/4, and 4/4 according to your comments.
I really appreciate your patch for the sparse warnings.
[...]
> /* Cf. IETF RFC 5101 Section 3.1. */
> struct ipfix_header {
> -uint16_t version; /*
On Fri, Jan 11, 2013 at 09:55:44AM -0800, Romain Lenglet wrote:
> Send one IPFIX data record message for every packet sampled by a
> sample_ipfix action, and send IPFIX template set messages
> periodically. Automatically generate standard IPFIX entity
> definitions from the IANA specs.
>
> Signed
On Thu, Jan 10, 2013 at 03:37:37PM -0800, Romain Lenglet wrote:
> On Jan 9, 2013, at 4:00 PM, Ben Pfaff wrote:
> > It looks like, in practice, the arguments to
> > ipfix_define_template_entity() are always fixed at compile time. If
> > I'm reading the code correctly, then this means that each cal
On Jan 9, 2013, at 4:00 PM, Ben Pfaff wrote:
> ipfix-gen-entities is only used at build time, that is, we do not
> install it, so I do not think it is worthwhile to generate it from a
> .in file. (For Python programs, that is mostly to get the right
> Python binary, which isn't necessary at buil
Continuing my review...
I just noticed that struct ipfix_data_record_common and other protocol
data structures lack the size assertions that we customarily include
to make sure that we haven't screwed up. For example:
BUILD_ASSERT_DECL(sizeof(struct ipfix_data_record_common) == 26);
(Hmm, tha
On Tue, Dec 18, 2012 at 11:52:12AM -0800, Romain Lenglet wrote:
> Send one IPFIX data record message for every packet sampled by a
> sample_ipfix action, and send IPFIX template set messages
> periodically. Automatically generate IPFIX entity definitions from
> the IANA specs.
>
> Signed-off-by:
